quilt icon indicating copy to clipboard operation
quilt copied to clipboard

Make JsonDisplay nested keys lighter

Open fiskus opened this issue 2 years ago • 3 comments

Before: 1 before

After: 2 after

fiskus avatar Feb 02 '23 12:02 fiskus

Codecov Report

Merging #3313 (f360020) into master (d3c490b) will increase coverage by 0.00%. The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master    #3313   +/-   ##
=======================================
  Coverage   35.18%   35.19%           
=======================================
  Files         674      674           
  Lines       29331    29337    +6     
  Branches     4336     4340    +4     
=======================================
+ Hits        10321    10325    +4     
- Misses      17835    17837    +2     
  Partials     1175     1175           
Flag Coverage Δ
api-python 90.79% <ø> (ø)
catalog 8.84% <66.66%> (+0.01%) :arrow_up:
lambda 86.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/JsonDisplay/JsonDisplay.js 0.00% <0.00%> (ø)
catalog/app/utils/JSONOneliner.ts 87.60% <100.00%> (+0.42%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Feb 02 '23 12:02 codecov[bot]

I think it was hard to read the one-liner, when it's not obvious which key are from the first level, and which from the second

fiskus avatar Feb 03 '23 10:02 fiskus

Maybe, I'll wait feedback from customer who wanted these key/values (visually separated) in packages list

fiskus avatar Feb 03 '23 10:02 fiskus