quilt icon indicating copy to clipboard operation
quilt copied to clipboard

Remove schema version restriction

Open flying-sheep opened this issue 2 years ago • 3 comments

You hardcode the list of supported JSON schema versions to just draft 7.

Is there any reason this is an allowlist instead of a blocklist? Otherwise it should be removed to allow using newer schema versions.

flying-sheep avatar Oct 25 '22 13:10 flying-sheep

There is a good reason for this: Quilt uses multiple JSON libraries (e.g. Javascript, Python) across the different parts of the catalog (including IGV visualizations), and that several of these libraries do not support a version of the JSON schema other than draft 7. Unfortunately it's not trivial to simultaneously support multiple drafts at this time. Removing the hardcoded JSON schema version may break parts of the application.

We're definitely looking to simplify this and support newer schema versions in the future, but just not at this moment.

robnewman avatar Oct 27 '22 15:10 robnewman

Leaving this open as it's totally possible (and desirable) to upgrade supported schema versions across JS and Python.

akarve avatar Oct 27 '22 15:10 akarve

There's also a deeper point here on white- versus blacklist and backwards compatibility.

akarve avatar Oct 27 '22 15:10 akarve