quilt
quilt copied to clipboard
Added `ui.search.mode` to `.quilt/catalog/config.yaml`
- Added
ui.search.mode
to .quilt/catalog/config.yaml - Refactored BucketPreferences.ts: added AsyncResult to return value. Used only in new code yet
- [x] Documentation
- [x] Changelog entry
Codecov Report
Merging #3129 (cf6bf3a) into master (32ff2c2) will decrease coverage by
80.40%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #3129 +/- ##
==========================================
- Coverage 88.78% 8.37% -80.41%
==========================================
Files 79 570 +491
Lines 9617 19039 +9422
Branches 0 4188 +4188
==========================================
- Hits 8538 1594 -6944
- Misses 1079 16266 +15187
- Partials 0 1179 +1179
Flag | Coverage Δ | |
---|---|---|
api-python | ? |
|
catalog | 8.37% <0.00%> (?) |
|
lambda | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
catalog/app/containers/Bucket/BucketNav.tsx | 0.00% <0.00%> (ø) |
|
catalog/app/containers/Bucket/Dir.tsx | 0.00% <0.00%> (ø) |
|
catalog/app/containers/Bucket/File.js | 0.00% <0.00%> (ø) |
|
...iners/Bucket/PackageDialog/PackageCreationForm.tsx | 0.00% <0.00%> (ø) |
|
.../app/containers/Bucket/PackageList/PackageList.tsx | 0.00% <0.00%> (ø) |
|
...iners/Bucket/PackageRevisions/PackageRevisions.tsx | 0.00% <0.00%> (ø) |
|
.../app/containers/Bucket/PackageTree/PackageTree.tsx | 0.00% <0.00%> (ø) |
|
...app/containers/Bucket/PackageTree/RevisionMenu.tsx | 0.00% <0.00%> (ø) |
|
...g/app/containers/Bucket/Queries/requests/athena.ts | 0.00% <0.00%> (ø) |
|
catalog/app/containers/Bucket/Search.js | 0.00% <0.00%> (ø) |
|
... and 652 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Yes, it's intentional on my side that search mode only works for bucket. But I didn't get feedback from Rob or Aneesh yet
Re-implemented here https://github.com/quiltdata/quilt/pull/3270