quilt icon indicating copy to clipboard operation
quilt copied to clipboard

Extend "S3 buckets with SSE-KMS" documentation

Open drernie opened this issue 1 year ago • 4 comments

Description

Add new sections technical-reference.md about explicit Allow permissions required by KMS

In order for Quilt to access and index buckets encrypted with SSE-KMS, you must do three things:

  1. Add KMS Key Usage to Quilt Permission Boundary
  2. Add Quilt Principals to KMS Key Policy [this was the old section]
  3. Add KMS Key Access to Quilt Role

drernie avatar Aug 29 '22 19:08 drernie

Codecov Report

Merging #3054 (58730c5) into master (2db5e08) will increase coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3054      +/-   ##
==========================================
+ Coverage   35.47%   35.49%   +0.02%     
==========================================
  Files         641      641              
  Lines       28327    28322       -5     
  Branches     4132     4133       +1     
==========================================
+ Hits        10049    10053       +4     
+ Misses      17096    17092       -4     
+ Partials     1182     1177       -5     
Flag Coverage Δ
api-python 90.72% <ø> (ø)
catalog 8.09% <ø> (+0.02%) :arrow_up:
lambda 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/Admin/Table.js 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Summary.js 0.00% <0.00%> (ø)
.../app/containers/Bucket/PackageTree/PackageTree.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Auth/wrapper.js
catalog/app/containers/Auth/wrapper.tsx 0.00% <0.00%> (ø)
.../containers/Bucket/PackageDialog/PackageDialog.tsx 26.61% <0.00%> (+0.29%) :arrow_up:
catalog/app/components/JsonEditor/State.js 62.75% <0.00%> (+1.22%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 29 '22 19:08 codecov[bot]

I think you forgot to commit images.

Whoops! Thanks. Fixed.

drernie avatar Aug 30 '22 17:08 drernie

I think you forgot to commit images.

Whoops! Thanks. Fixed.

But what about admin-policy-*.png?

sir-sigurd avatar Aug 30 '22 17:08 sir-sigurd

I think you forgot to commit images.

Whoops! Thanks. Fixed.

But what about admin-policy-*.png?

Ah! Forgot to pull everything over from old branch. Pushed now git checkout athena-config -- docs/imgs

drernie avatar Aug 30 '22 18:08 drernie