quilt icon indicating copy to clipboard operation
quilt copied to clipboard

Bump mod_zip: allow empty zip files

Open dimaryaz opened this issue 2 years ago • 2 comments

See https://github.com/quiltdata/mod_zip/commit/979314cca0507a59071310f09401861cced73ccb

Will make the registry code simpler.

dimaryaz avatar Aug 18 '22 05:08 dimaryaz

Codecov Report

Merging #2991 (326c6e7) into master (ea4d360) will increase coverage by 53.67%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2991       +/-   ##
===========================================
+ Coverage   35.16%   88.83%   +53.67%     
===========================================
  Files         663       79      -584     
  Lines       29094     9664    -19430     
  Branches     4281        0     -4281     
===========================================
- Hits        10230     8585     -1645     
+ Misses      17675     1079    -16596     
+ Partials     1189        0     -1189     
Flag Coverage Δ
api-python 90.79% <ø> (ø)
catalog ?
lambda 86.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/Thumbnail/Thumbnail.js
...app/containers/Bucket/PackageTree/RevisionMenu.tsx
...cket/PackageDialog/gql/PackagePromote.generated.ts
catalog/app/website/components/Lede/index.tsx
catalog/app/components/Dropzone/Dropzone.js
catalog/app/constants/quiltConfigs.ts
catalog/app/utils/LogicalKeyResolver.tsx
...ainers/Admin/RolesAndPolicies/AttachedPolicies.tsx
catalog/app/containers/Bucket/requests/index.ts
catalog/app/components/Experiments/index.js
... and 574 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 18 '22 05:08 codecov[bot]

@dimaryaz @sir-sigurd Can we cleanly merge this with master and deploy?

robnewman avatar Sep 27 '22 03:09 robnewman

@dimaryaz @sir-sigurd Can we get this merged with master and squashed?

robnewman avatar Dec 19 '22 18:12 robnewman

Oh, forgot about this one. But actually, my fixes got merged upstream, so let me test it and see if everything works.

dimaryaz avatar Dec 19 '22 19:12 dimaryaz

Actually, the other two patches got upstreamed, but I haven't sent out this one. Hopefully, this one will make it someday, too.

dimaryaz avatar Dec 19 '22 19:12 dimaryaz