quilt icon indicating copy to clipboard operation
quilt copied to clipboard

Add Readme split button

Open fiskus opened this issue 2 years ago • 1 comments

Description

Use split button to select README.txt or README instead of README.md

Screenshot from 2022-08-11 18-28-07 Screenshot from 2022-08-11 18-28-23

TODO

  • [ ] ~Unit tests~
  • [ ] ~Automated tests (e.g. Preflight)~
  • [ ] ~Documentation~
    • [ ] ~Python: Run build.py for new docstrings~
    • [ ] ~JavaScript: basic explanation and screenshot of new features~
  • [ ] Changelog entry

fiskus avatar Aug 11 '22 15:08 fiskus

Codecov Report

Merging #2979 (1270f47) into master (f3c5249) will decrease coverage by 53.51%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master    #2979       +/-   ##
===========================================
- Coverage   89.31%   35.80%   -53.52%     
===========================================
  Files          76      626      +550     
  Lines        9520    27906    +18386     
  Branches        0     4060     +4060     
===========================================
+ Hits         8503     9992     +1489     
- Misses       1017    16752    +15735     
- Partials        0     1162     +1162     
Flag Coverage Δ
api-python 90.72% <ø> (ø)
catalog 8.09% <0.00%> (?)
lambda 87.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/FileEditor/loader.ts 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Summary.js 0.00% <0.00%> (ø)
catalog/app/utils/wait.ts 0.00% <0.00%> (ø)
...esAndPolicies/gql/PolicyCreateManaged.generated.ts 0.00% <0.00%> (ø)
catalog/app/components/Preview/renderers/Voila.tsx 0.00% <0.00%> (ø)
catalog/app/components/Preview/renderers/Text.js 0.00% <0.00%> (ø)
catalog/app/components/StackedAreaChart/index.js 0.00% <0.00%> (ø)
catalog/app/components/Preview/loaders/Text.js 56.52% <0.00%> (ø)
catalog/app/website/pages/OpenProfile/index.js 0.00% <0.00%> (ø)
...atalog/app/website/pages/Landing/Platform/index.js 0.00% <0.00%> (ø)
... and 542 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 11 '22 15:08 codecov[bot]

I hope we will remove this feature, actually. Leaving the user ability to create "Readme.md" only, but extending functionality of text editor where he could rename Readme.md to whatever he wants. So, let's use this less convenient but already implemented split button

fiskus avatar Aug 24 '22 09:08 fiskus