quilt icon indicating copy to clipboard operation
quilt copied to clipboard

Overwrite AppBar default orange color

Open fiskus opened this issue 1 year ago • 1 comments

We use navTheme.palette.seconday.dark for color, but AppBar extracts .main (so, <AppBar color="secondary" doesn't help) Sometimes, this primary.main orange flashes during first load (maybe even once after deploy)

fiskus avatar Aug 04 '22 15:08 fiskus

Codecov Report

Merging #2969 (964f38e) into master (fe2c6b2) will decrease coverage by 50.36%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2969       +/-   ##
===========================================
- Coverage   89.31%   38.95%   -50.37%     
===========================================
  Files          76      615      +539     
  Lines        9519    27462    +17943     
  Branches        0     4003     +4003     
===========================================
+ Hits         8502    10697     +2195     
- Misses       1017    15629    +14612     
- Partials        0     1136     +1136     
Flag Coverage Δ
api-python 90.71% <ø> (ø)
catalog 12.23% <ø> (?)
lambda 87.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/NavBar/NavBar.tsx 18.32% <ø> (ø)
...alog/app/containers/Bucket/WorkflowsConfigLink.tsx 42.85% <0.00%> (ø)
catalog/app/website/pages/Example.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/requests/package.ts 43.47% <0.00%> (ø)
...min/RolesAndPolicies/gql/PolicyDelete.generated.ts 0.00% <0.00%> (ø)
catalog/app/constants/urls.js 100.00% <0.00%> (ø)
catalog/app/utils/img2x.js 0.00% <0.00%> (ø)
catalog/app/embed/Embed.js 0.00% <0.00%> (ø)
...log/app/containers/Bucket/PackageDialog/actions.ts 0.00% <0.00%> (ø)
catalog/app/components/Markdown/Markdown.tsx 0.00% <0.00%> (ø)
... and 530 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Aug 04 '22 15:08 codecov[bot]

Still not fixed. I think we need a more in-depth refactoring of layout

fiskus avatar Sep 13 '22 09:09 fiskus