quilt
quilt copied to clipboard
Show logicalKey instead of physicalKey for summary file
Show logicalKey
as a title for files from quilt_summarize.json
-
withoutPrefix(getPrefix(key), key)
replaced withgetBasename(key)
- Move reused code parts to functions
Codecov Report
Merging #2300 (885c692) into master (91e4188) will decrease coverage by
0.00%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #2300 +/- ##
==========================================
- Coverage 35.47% 35.47% -0.01%
==========================================
Files 641 641
Lines 28337 28339 +2
Branches 4136 4135 -1
==========================================
Hits 10053 10053
- Misses 17106 17108 +2
Partials 1178 1178
Flag | Coverage Δ | |
---|---|---|
api-python | 90.72% <ø> (ø) |
|
catalog | 8.09% <0.00%> (-0.01%) |
:arrow_down: |
lambda | 86.05% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
catalog/app/containers/Bucket/Summarize.tsx | 0.00% <0.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
and logicalKey seems like front end of s3 handle
i don't think it's quite correct -- s3 handle with logicalKey is a special case of s3 handle and only occurs inside packages (it feels like a leaking abstraction actually)
But right now I don't know cases where logicalKey is different from physical key
this can happen in any package, and in general case we should not assume logical and physical keys are related in any way (they are often the same for most of our day to day testing cases, bc that's how the catalog package creation ui works, but that's not true in general)
Reverted controversial code, and just moved duplicated code to functions