quilt
quilt copied to clipboard
Require auth for Package dialogs
- [ ] Replace $TSFixMe with actual type
Codecov Report
Merging #2227 (68ca5d6) into master (41fb30d) will decrease coverage by
0.02%
. The diff coverage is12.12%
.
@@ Coverage Diff @@
## master #2227 +/- ##
==========================================
- Coverage 44.31% 44.28% -0.03%
==========================================
Files 491 492 +1
Lines 23462 23473 +11
Branches 2987 2988 +1
==========================================
- Hits 10397 10395 -2
- Misses 12178 12195 +17
+ Partials 887 883 -4
Flag | Coverage Δ | |
---|---|---|
api-python | 89.85% <ø> (ø) |
|
catalog | 14.76% <12.12%> (-0.03%) |
:arrow_down: |
lambda | 93.93% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
catalog/app/containers/Auth/protectDialog.tsx | 0.00% <0.00%> (ø) |
|
catalog/app/containers/Bucket/PackageList.js | 0.00% <0.00%> (ø) |
|
catalog/app/containers/Bucket/PackageTree.js | 0.00% <0.00%> (ø) |
|
...alog/app/containers/Bucket/PackageUpdateDialog.tsx | 0.00% <0.00%> (ø) |
|
catalog/app/containers/Auth/wrapper.tsx | 50.00% <19.04%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 41fb30d...68ca5d6. Read the comment docs.
It's not trivial to add auth wrapper now: components are no longer simple components, and need to deal with circular dependencies
I separated conversion to .tsx: https://github.com/quiltdata/quilt/pull/3084