quilt icon indicating copy to clipboard operation
quilt copied to clipboard

Increase bucket dropdown height

Open fiskus opened this issue 3 years ago • 3 comments

  • make the default menu taller (fits 10 items on 1080p)
  • end on a half list item so user keeps scrolling

Screenshot from 2021-06-07 17-23-51

Screenshot from 2021-06-07 17-30-15

fiskus avatar Jun 07 '21 14:06 fiskus

Codecov Report

Merging #2226 (2efd6b5) into master (e4a11af) will increase coverage by 0.00%. The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2226   +/-   ##
=======================================
  Coverage   44.92%   44.92%           
=======================================
  Files         465      465           
  Lines       22990    22992    +2     
  Branches     2859     2859           
=======================================
+ Hits        10329    10330    +1     
- Misses      11745    11746    +1     
  Partials      916      916           
Flag Coverage Δ
api-python 89.85% <ø> (ø)
catalog 15.01% <50.00%> (+<0.01%) :arrow_up:
lambda 94.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/NavBar/BucketSelect.js 26.76% <50.00%> (+0.67%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e4a11af...2efd6b5. Read the comment docs.

codecov[bot] avatar Jun 07 '21 14:06 codecov[bot]

also, 52vh may be a little too small on smaller (phone) screens

nl0 avatar Jun 07 '21 14:06 nl0

I'm not happy with this solution I will get back to it later

fiskus avatar Oct 22 '21 09:10 fiskus

Solution is based on hard-coded number. The value of this PR is not so strong to bring code smell into codebase

fiskus avatar Sep 13 '22 09:09 fiskus