quilc icon indicating copy to clipboard operation
quilc copied to clipboard

Nonrecursive contiguous subschedule

Open erichulburd opened this issue 4 years ago • 3 comments

Rebases https://github.com/quil-lang/quilc/pull/693 which should fix tests.

Closes https://github.com/rigetti/quilc/issues/697

erichulburd avatar Jun 07 '21 20:06 erichulburd

Both @stylewarning (me!) and @kilimanjaro will take a look.

stylewarning avatar Jul 01 '21 18:07 stylewarning

I'm a bit sketched out by the original code, and also by the changes here.

Unnecessarily unfriendly language IMO

notmgsk avatar Jul 01 '21 21:07 notmgsk

I'm a bit sketched out by the original code, and also by the changes here.

Unnecessarily unfriendly language IMO

I didn't mean it as a strong statement, but rather that it's hard for me to look at the code (e.g. even as originally written) and say if it is correct or not (or if it would break if the logical scheduler code changed, etc).

braised-babbage avatar Jul 01 '21 22:07 braised-babbage