qlog icon indicating copy to clipboard operation
qlog copied to clipboard

Add optional src and dst address for `TransportPacket*` events

Open lnicco opened this issue 2 years ago • 3 comments

Add optional src and dst address for TransportPacketSent, TransportPacketReceived, TransportPacketDropped, TransportPacketBuffered

Fixes #57

lnicco avatar Jul 18 '22 05:07 lnicco

Actually this should be for the Datagram events and not for Packet events TransportDatagramsSent TransportDatagramsReceived TransportDatagramDropped

lnicco avatar Jul 18 '22 16:07 lnicco

As mentioned in #57, I would rather see this (and some of the other events we have that list IPs/ports, like ConnectivityConnectionStarted) updated to a generic PathInfo struct (or similar).

This does depend a bit on how we approach migration events (as they probably want to re-use this too). (also depends on multipath approach, but since it looks like we're not doing that, we can skip it).

In short: this is not yet ready for review/merge atm :)

rmarx avatar Sep 16 '22 13:09 rmarx

Overtaken by #336?

LPardue avatar Nov 17 '23 21:11 LPardue

This was indeed solved (or at least changed in a different way) by #336, so closing without merging.

rmarx avatar Jun 27 '24 18:06 rmarx