quickwit icon indicating copy to clipboard operation
quickwit copied to clipboard

Published 20 hours ago • verified publisher icon quickwit-oss

Issue/2042

Open nigel-andrews opened this issue 3 years ago • 2 comments

Description

Changed the IndexRecordOption to an option that is now set to None from an IndexRecordOption::Basic

How was this PR tested?

Cargo test to check for regression and successfully created the index defined in issue #2042 . Added some unit tests to ensure the correct behaviour

nigel-andrews avatar Oct 06 '22 10:10 nigel-andrews

Let's take the opportunity of this PR to add the same check for QuickwitJsonOptions.

Should record in QuickwitJsonOptions also be an Option then ?

nigel-andrews avatar Oct 06 '22 21:10 nigel-andrews

@nigel-andrews probably. 1- Add a similar unit test and tell us if it is necessary 2- if it is not broken today, dig into it and explain why it is different... do we have a check missing etc.

fulmicoton avatar Oct 07 '22 05:10 fulmicoton