quickwit icon indicating copy to clipboard operation
quickwit copied to clipboard

add LocalFileStorage delay to simulate s3

Open PSeitz opened this issue 2 years ago • 1 comments

PSeitz avatar Jun 17 '22 08:06 PSeitz

Good idea, but making it a feature is not a good idea.

  • --all-features will enable it and no one expects that.
  • also it requires recompiling things way too much.

In many places, rust treats feature flags as additive semantically. It is not supposed to change the behavior (we make that mistake in tantivy I think too).

For instnace, if deps A and deps B depends on C with feature flag [feaflag1] and [featflag2] and compatible versions, rustc will compile a single version of C with [featflag1, featflag2].

fulmicoton avatar Jun 21 '22 01:06 fulmicoton