quicklisp-projects icon indicating copy to clipboard operation
quicklisp-projects copied to clipboard

Please add adp-plain and adp-github

Open HectareaGalbis opened this issue 2 years ago • 7 comments

Recently, I modified the project adp. Now it extends ASDF to support scribble-like files. It just defines the core functionality, and it needs exporters that will define useful functions and will create the output files.

adp now depends on fare/scribble that was recently updated due to an issue.

So, I want to add two simple exporters, adp-plain and adp-github.

  • adp-plain:

    • Source code: https://github.com/Hectarea1996/adp-plain
    • Extends adp with really simple functionality. It allows you to select which file will be created from a scribble one. It can be extended by the user defining new scribble (actually lisp) functions.
  • adp-github:

    • Source code: https://github.com/Hectarea1996/adp-github
    • Extends adp with extra functionality to create files with Github Flavoured Markdown format. You can create files using table of contents, cross references, etc.

HectareaGalbis avatar Oct 29 '23 08:10 HectareaGalbis

Build errors with both of them: https://github.com/ocicl/adp-github/actions/runs/6683586853/job/18159938440#step:2:859

atgreen avatar Oct 29 '23 13:10 atgreen

The error comes because i'm using a package available from SBCL. Do I have a more recent version of SBCL?

Anyway, I updated the project that should fix the error.

HectareaGalbis avatar Oct 29 '23 14:10 HectareaGalbis

Is the project SBCL-only? If so, I can't accept it.

quicklisp avatar Oct 29 '23 14:10 quicklisp

It is not. I used the #+sbcl feature in some places, but the rest should be standard code.

HectareaGalbis avatar Oct 29 '23 15:10 HectareaGalbis

Hi again. I want to apologize. I have realized that my project doesn't meet the quality required by Quicklisp. I'll try to do better software in the future.

Sorry, and thanks for the amazing work!

HectareaGalbis avatar Nov 26 '23 10:11 HectareaGalbis

There's no quality threshold for quicklisp. If it builds on more than one Lisp it's fine. If you still wish to withdraw it that's fine too.

On Sun, Nov 26, 2023 at 5:02 AM Hectarea @.***> wrote:

Hi again. I want to apologize. I have realized that my project doesn't meet the quality required by Quicklisp. I'll try to do better software in the future.

Sorry, and thanks for the amazing work!

— Reply to this email directly, view it on GitHub https://github.com/quicklisp/quicklisp-projects/issues/2373#issuecomment-1826740313, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPNLLK7J6GQ62ICYE6VNTYGMHR5AVCNFSM6AAAAAA6UWCUSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWG42DAMZRGM . You are receiving this because you commented.Message ID: @.***>

quicklisp avatar Nov 26 '23 16:11 quicklisp

I think I'd rather not do it yet. It is true that some functionality only works with sbcl. So, maybe it is better to wait until I improve the project.

HectareaGalbis avatar Nov 26 '23 16:11 HectareaGalbis