quicklisp-projects icon indicating copy to clipboard operation
quicklisp-projects copied to clipboard

please replace cl-protobufs in gitlab with cl-protobufs on github

Open Slids opened this issue 4 years ago • 11 comments

https://github.com/qitab/cl-protobufs

The current version on quicklisp is the gitlab repo. I would like to keep that on Gitlab for historic purposes, but it has been re open sourced and should point to the new code.

Theres a fairly extensive readme, though the description in the asd is minimal to say the least...

Slids avatar Jul 28 '20 04:07 Slids

This build procedure is too complex for Quicklisp. Is there a way it can be simplified?

quicklisp avatar Aug 26 '20 18:08 quicklisp

We could add the pre-built well-known-types to the package so you don't need protoc to build the project, but ti would still require protoc to run the tests. Is this okay?

Slids avatar Aug 26 '20 19:08 Slids

That could work - what version of protoc is required?

On Wed, Aug 26, 2020 at 3:54 PM Jon Godbout [email protected] wrote:

We could add the pre-built well-known-types to the package so you don't need protoc to build the project, but ti would still require protoc to run the tests. Is this okay?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/quicklisp/quicklisp-projects/issues/1879#issuecomment-681090735, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPNLLPUDNADT3BZ3SXNZ3SCVSA7ANCNFSM4PKBWDNQ .

quicklisp avatar Aug 26 '20 20:08 quicklisp

To run the tests? You have to download the protcol-buffers repo, the cl-protobufs repo, and make them both. That will give you the protoc-gen-lisp protoc plugin. It's annoying, but it only needs to be done once, then so long as you have a new protoc-gen-lisp in you $path you can just use cl-protobufs.

You can however run the lisp protoc on your .proto files and just package that, then there's no need to call all of that. We can manually run protoc on the stuff required to build the base cl-protobufs and package that. Does that make sene?

Slids avatar Aug 26 '20 21:08 Slids

Ah, I think that works for me, thanks.

On Wed, Aug 26, 2020 at 5:40 PM Jon Godbout [email protected] wrote:

To run the tests? You have to download the protcol-buffers repo, the cl-protobufs repo, and make them both. That will give you the protoc-gen-lisp protoc plugin. It's annoying, but it only needs to be done once, then so long as you have a new protoc-gen-lisp in you $path you can just use cl-protobufs.

You can however run the lisp protoc on your .proto files and just package that, then there's no need to call all of that. We can manually run protoc on the stuff required to build the base cl-protobufs and package that. Does that make sene?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/quicklisp/quicklisp-projects/issues/1879#issuecomment-681138219, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPNLPFAZLU57KRPOAS6UTSCV6MFANCNFSM4PKBWDNQ .

quicklisp avatar Aug 26 '20 21:08 quicklisp

Ben is working on it: https://github.com/qitab/cl-protobufs/pull/192

Slids avatar Aug 27 '20 22:08 Slids

Is protoc-gen-lisp still required to compile and load the system?

quicklisp avatar Sep 19 '20 14:09 quicklisp

Sorry, Ben has a pr but we're waiting for cdr to review...

Slids avatar Sep 19 '20 18:09 Slids

Some people are getting this now, is it related? Symbol "LENGTH64" not found in the VARINT package.

quicklisp avatar Sep 20 '20 13:09 quicklisp

I don't see it's loading without installing protoc at the moment... Also there is no varint package.

What common lisp is this showing up in, also what version? I only expect cl-protobufs to work on abcl, ccl, and sbcl

Slids avatar Sep 20 '20 14:09 Slids

My mistake - VARINT is from Robert Brown's protobuf project.

On Sun, Sep 20, 2020 at 10:33 AM Jon Godbout [email protected] wrote:

I don't see it's loading without installing protoc at the moment... Also there is no varint package.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/quicklisp/quicklisp-projects/issues/1879#issuecomment-695794134, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPNLJXVL3H7QOYYTOCM6DSGYHE5ANCNFSM4PKBWDNQ .

quicklisp avatar Sep 21 '20 12:09 quicklisp