quicklisp-projects icon indicating copy to clipboard operation
quicklisp-projects copied to clipboard

New version of cl-base64, update source repo

Open phmarek opened this issue 5 years ago • 11 comments

Please use the version from https://github.com/jdz/cl-base64 which has quite a few fixes.

The old one from kpe goes OOM when running (base64:base64-string-to-string nil), for example.

phmarek avatar Apr 07 '20 15:04 phmarek

Have you contacted Kevin about incorporating bug fixes?

quicklisp avatar Apr 08 '20 11:04 quicklisp

Yes, I sent an email yesterday... But as the latest contribution on http://git.kpe.io/ is 2 years ago I went and found the newer jdz repo - that looks actively maintained.

phmarek avatar Apr 08 '20 11:04 phmarek

I'm not going to switch without some discussion with the original author. Please allow some time for him to respond. If there is no timely response, we can revisit. If you want something sooner, fork it with a new name.

quicklisp avatar Apr 08 '20 12:04 quicklisp

No problem. It's 3 weeks until the next QL release anyway ;)

"fork it" as in "fork QL" or "fork CL-BASE64"? The jdz repo has all the commits of the original one, plus a few more commits - the important one might be the one removing (safety 0) - so forking with a new name doesn't make sense to me...

phmarek avatar Apr 08 '20 14:04 phmarek

"Fork CL-BASE64" as in, make a project with the desired fixes with a new name.

It's better to work with the original author before/instead of doing that, though.

quicklisp avatar Apr 08 '20 14:04 quicklisp

(Absolute nitpick: I don't think we need a fifth base64 library in Quicklisp.)

phoe avatar Apr 08 '20 14:04 phoe

We would do well to fix our perennial Discoverability Problem and consolidate a bit, yes.

Hexstream avatar Apr 08 '20 17:04 Hexstream

For the record I've sent a mail to Kevin (at rosenberg.net) on July 8, 2019.

I personally would like if my changes were merged into the original project. But I also don't have the energy to chase the author around. I'm grateful for the effort people have put into creating a library, and I also can understand that their life priorities may have changed.

It would be nice if anybody could get a response from Kevin about his ability to do CL library maintenance. Maybe it would be beneficial for the community if the projects were moved to sharplispers?

jdz avatar Apr 09 '20 09:04 jdz

If no one did not get a response from Kevin, I vote for moving the project over to @sharplispers and maintaining it there.

phoe avatar Apr 28 '20 11:04 phoe

Well, IMO is as good a maintainer as we'll ever get, so why not just switch over? Of course, asking him to donate that repo to the sharplispers might be a good idea as well...

phmarek avatar Apr 28 '20 11:04 phmarek

Hi Jānis, thanks for the improvements on this package. Phil Marek just let me know about your repository and I'm very happy to merge your improvements.

kevinrosenberg avatar Sep 30 '20 18:09 kevinrosenberg