quickfix icon indicating copy to clipboard operation
quickfix copied to clipboard

Trim extra non-ascii characters that can arise from manually editing …

Open adam-talos opened this issue 4 years ago • 1 comments

…sequence number files.

When we run into sequence. number issues and want to fix the issue on the server, if you edit the sequence number files with something like vi, it may add a newline or carriage return even if you don't mean to and QuickFIX will not honor the sequence number.

This fix trims the extra junk off the end so that QuickFIX can read the new value without needing to do a "truncate -s -1" or similar hackery.

links to issue #464

adam-talos avatar Sep 30 '21 20:09 adam-talos

The CI failure looks unrelated to the change. The build timed out doing a lint check.

adam-talos avatar Oct 01 '21 12:10 adam-talos

On a re-run it does kick out

filestore.go:225: File is not gofmt-ed with -s (gofmt) if targetSeqNum, err := strconv.Atoi(strings.Trim(string(targetSeqNumBytes),"\r\n")); err == nil {

Give that a quick fix and I will merge!

ackleymi avatar Oct 26 '23 22:10 ackleymi

@adam-talos thanks 👍

ackleymi avatar Oct 27 '23 17:10 ackleymi