quickfix
quickfix copied to clipboard
Trim extra non-ascii characters that can arise from manually editing …
…sequence number files.
When we run into sequence. number issues and want to fix the issue on the server, if you edit the sequence number files with something like vi, it may add a newline or carriage return even if you don't mean to and QuickFIX will not honor the sequence number.
This fix trims the extra junk off the end so that QuickFIX can read the new value without needing to do a "truncate -s -1" or similar hackery.
links to issue #464
The CI failure looks unrelated to the change. The build timed out doing a lint check.
On a re-run it does kick out
filestore.go:225: File is not
gofmt-ed with-s(gofmt) if targetSeqNum, err := strconv.Atoi(strings.Trim(string(targetSeqNumBytes),"\r\n")); err == nil {
Give that a quick fix and I will merge!
@adam-talos thanks 👍