quickfixj
quickfixj copied to clipboard
quickfix-j
Assure compatibility with FIX Orchestra generated QFJ dictionary
Fixes #336
Tests to assure compatibility with FIX Orchestra generated QFJ dictionary : issue-336
see https://github.com/quickfix-j/quickfixj/issues/336
@chrjohn Is there a way to rerun failed checks , I'm pretty sure that concurrency problem in the JDK15 check is not due to this change :-)
Can't you re-run the checks from the Checks tab? But maybe you are not allowed to do so. Otherwise close and reopen the PR should work but is of course ugly.
git commit -m "retrigger checks" --allow-empty && git push <remote> HEAD I will try the close and re-open next time.
@chrjohn I think that there are instabilities in the test cases. perhaps on windows specifically ? Do you see this concurrent modification exception in other builds ?
@david-gibbs-ig , could you please check the formatting on this change? It seems the indentation is sometimes two spaces, sometimes four... Thanks in advance.
I've have converted the tabs to spaces, also updated Apache Mina version to address a security patch. See the release notes here https://mina.apache.org/mina-project/.