quickemu icon indicating copy to clipboard operation
quickemu copied to clipboard

πŸ—οΈ Lint PRs + OS pack πŸ¦₯ 1

Open zen0bit opened this issue 1 year ago β€’ 4 comments

Included:

πŸ—οΈ Lint PRs πŸ“¦ Artix Linux - First time in #758 - πŸš₯ πŸ“¦ Athena OS - in #750 - πŸš₯ πŸ“¦ bazzite - in #797 πŸ“¦ Big Linux Thanks to @ruscher - in #748 πŸ›  BlendOS releases on 1 line πŸ“¦ Chimera Linux - in #781 πŸ“¦ Crunchbang++ - in #881 πŸš‘ EasyOS fix and new releases - in #924 fix #921 πŸŒ€ EndeavourOS dynamic releases Thanks to @lj3954 - in #907 πŸ›  Gentoo livegui - in #905 πŸ“¦ Guix - in #768 πŸ“¦ Nitrux - in #873 πŸ“¦ Parrot Security - in #893 πŸ“¦ Primtux Thanks to @DaffyDuke - in #887 πŸ“¦ Slax - in #761 πŸ“¦ Slint - in #889 πŸ“¦ Slitaz GNU/Linux - in #664 - πŸš₯ πŸ“¦ SparkyLinux - in #799 πŸ›  spiral rename πŸ›  ️Zorin 17 - in #880

  • picture legend πŸš₯ = Allready approved by @flexiondotorg πŸ—οΈ = workflow πŸ“¦ = new OS πŸ›  = changed OS πŸš‘ = fix bug πŸŒ€ = dynamic parsing

zen0bit avatar Jan 19 '24 14:01 zen0bit

Once again, you need to test the changes you make. Echoing a variable with quotation marks preserves new lines and other special characters. The releases and editions functions are supposed to separate entries with spaces, not new lines. If you insist on "fixing" incorrect ShellCheck errors, you must replace new lines with spaces in another way, such as by piping the output to tr '\n' ' '.

lj3954 avatar Jan 20 '24 19:01 lj3954

I recommend to remove " 14.2.1" at end of line 880 as this Slint release is no more supported, so won't receive security fixes any more.

DidierSpaier avatar Jan 29 '24 16:01 DidierSpaier

Once again, you need to test the changes you make. Echoing a variable with quotation marks preserves new lines and other special characters. The releases and editions functions are supposed to separate entries with spaces, not new lines. If you insist on "fixing" incorrect ShellCheck errors, you must replace new lines with spaces in another way, such as by piping the output to tr '\n' ' '.

I don't have to. I am creating github action to check for me, if I don't broke something πŸ˜‰

error You see?

zen0bit avatar Feb 10 '24 11:02 zen0bit

I recommend to remove " 14.2.1" at end of line 880 as this Slint release is no more supported, so won't receive security fixes any more.

Bit forgot, but done now...

zen0bit avatar Feb 10 '24 11:02 zen0bit

Closed via #986

flexiondotorg avatar Apr 11 '24 21:04 flexiondotorg