quick-lint-js icon indicating copy to clipboard operation
quick-lint-js copied to clipboard

Published 20 hours ago • verified publisher icon quick-lint

Check Go version in tools/update-translator-sources

Open Rebraws opened this issue 2 years ago • 1 comments

I wanted to test something with the quick-lint-js CLI tool, and I noticed that the script tools/compile-translations.go gives an error when using a version of Go lower than 1.16.

Error: undefined: os.ReadDir

I think it would be nice if instead of crashing, the script tools/update-translator-sources performed a version check and displayed a message like Requires at least Go 1.16. if the requirement isn't met.

Maybe it could be a good first issue for someone new to programming.

Rebraws avatar Sep 06 '22 18:09 Rebraws

Good idea. We should also check that gettext is installed (xgettext msgmerge commands). Or at least document all of this in docs/TRANSLATING.md.

strager avatar Sep 06 '22 19:09 strager

Implemented in commit 2d93a6726de32df9d062109b9f40b0ab5430ed91.

strager avatar Jan 29 '23 06:01 strager