aimet icon indicating copy to clipboard operation
aimet copied to clipboard

Updated code for conda, python 3.7, PyTorch 1.8, cuda 10/11 on ubuntu 20.04

Open mikeseven opened this issue 3 years ago • 4 comments

This PR updates AIMET to almost latest versions of various dependencies in a conda environment.

  • aimet environment in packaging/environment.yml
  • Python 3.7
  • google test 1.10
  • cuda 10 and 11

Tensorflow remains at 1.15 since AIMET uses deprecated contrib code not available in TF 2. Hopefully, AIMET team would upgrade one day!

Conda TF 1.15 conflicts with Pytorch on cuda, forcing Pytorch to be CPU only. There is no such issue with TF 2.

Most tests passes (dobuildntest.sh -u) though many have errors regardless of CPU or GPU. AIMET team, please check.

No update on docker containers. Still on old versions with many tests not passing.

AIMET team, please help make this code robust.

mikeseven avatar May 01 '21 18:05 mikeseven

PR is failing because your CI is using an older version of cmake. Without newer version, Cuda and lapack are not correctly found and linked on conda environments. @quic-akhobare please upgrade.

mikeseven avatar May 05 '21 16:05 mikeseven

@mikeseven Thank you for pushing this update. Sorry about the delayed response. And, a quick note - we are working on updating AIMET to support TF2.0. @quic-akhobare @quic-bharathr could you please review this update?

quic-ssiddego avatar Jul 06 '21 17:07 quic-ssiddego

Can't wait to test the new version with TF 2. Any tentative timeline? The updates in this PR are really for build purpose ie. they should work with TF2 too.

mikeseven avatar Jul 06 '21 19:07 mikeseven

Can't wait to test the new version with TF 2. Any tentative timeline? The updates in this PR are really for build purpose ie. they should work with TF2 too.

Difficult to project an ETA at the moment.

So one thing we realized that several contrib modules got deprecated and removed in TF 2.4. E.g. AIMET currently depends on contrib.quantize.python.graph_matcher module in TF 1.15. This is not present in TF 2.4. We are looking at alternatives. @mikeseven If you are familiar with this module by chance, any suggestions would be welcome.

quic-akhobare avatar Jul 06 '21 20:07 quic-akhobare