questdb icon indicating copy to clipboard operation
questdb copied to clipboard

chore(core): introduce separate set of permissions for ILP

Open puzpuzpuz opened this issue 1 year ago • 1 comments

Depends on #3525

Introduces separate permission checks for ILP in SecurityContext: create table, add column, insert.

Also includes the following:

  • Fix incomplete exception and timeout handling in AsyncFilteredNegativeLimitRecordCursor.
  • Use error level for errors logged by AsyncFilteredRecordCursor and AsyncFilteredNegativeLimitRecordCursor. That's to prevent false positive critical level logging in the case of ImplicitCastException and similar non-critical ones.

puzpuzpuz avatar Jul 04 '23 12:07 puzpuzpuz

[PR Coverage check]

:heart_eyes: pass : 79 / 91 (86.81%)

file detail

path covered line new line coverage
:large_blue_circle: io/questdb/cairo/security/ReadOnlySecurityContext.java 0 3 00.00%
:large_blue_circle: io/questdb/griffin/engine/table/AsyncFilteredRecordCursor.java 2 4 50.00%
:large_blue_circle: io/questdb/griffin/engine/table/AsyncFilteredNegativeLimitRecordCursor.java 32 36 88.89%
:large_blue_circle: io/questdb/cairo/CairoEngine.java 35 38 92.11%
:large_blue_circle: io/questdb/cutlass/line/tcp/LineTcpMeasurementScheduler.java 3 3 100.00%
:large_blue_circle: io/questdb/cairo/sql/async/PageFrameSequence.java 1 1 100.00%
:large_blue_circle: io/questdb/cutlass/line/tcp/TableUpdateDetails.java 1 1 100.00%
:large_blue_circle: io/questdb/cutlass/line/tcp/LineTcpMeasurementEvent.java 2 2 100.00%
:large_blue_circle: io/questdb/cairo/security/AllowAllSecurityContext.java 3 3 100.00%

ideoma avatar Jul 10 '23 08:07 ideoma