smui icon indicating copy to clipboard operation
smui copied to clipboard

Published 20 hours ago • verified publisher icon querqy

Remove the table name from the query structure.

Open epugh opened this issue 4 years ago • 2 comments
trafficstars

This PR is based on experimenting with SMUI with sqlserver and mysql databases. SQLServer specifically didn't like the table name being part of the column names. With this PR (and some tweaks to the schema) SMUI could run against SQLServer.

I thought more about it, and thought that not having the table name in the rowparser would make it easier to read.

I don't know if there are any other simplifications that could be made?

epugh avatar Apr 21 '21 20:04 epugh

Thanks , @epugh for the PR. It needs to be checked , if removing the table prefixes will break the test automation (hint: some JOINs are used in the EventHistory feature).

I understand , removing the table prefixes is necessary in order to have a broader DBMS support like suggested in #69 .

pbartusch avatar May 14 '21 11:05 pbartusch

BTW, I did run these tests:

➜  smui-o19s git:(simplify_sql_query_structure) ./runE2ETests.sh

epugh avatar May 14 '21 17:05 epugh