qhue icon indicating copy to clipboard operation
qhue copied to clipboard

Move create_new_username() into bridge as static function

Open NicoHood opened this issue 7 years ago • 1 comments

In order to avoid naming conflicts and to get a better idea from which lib we are creating a new user, all static functions should be moved into the Bridge class. Does this sound good to you?

NicoHood avatar Dec 16 '17 06:12 NicoHood

Hi Nico -

In general, I agree, though there are enough people using the library now that I'd like to avoid backwards incompatibility where possible. So I think we should keep the module-level functions (some of which were contributed by others), even if they simply call class methods on the Bridge class. We can mark them as deprecated.

Feel free to send a pull request and I'll have a look.

quentinsf avatar Dec 16 '17 11:12 quentinsf