Quentin Smith

Unfortunately the rotctld protocol doesn't expose anything about the target state of the rotator (target azimuth, move/stop/park, etc.), so we would have to keep track of the most recent command...

I found some interesting prior art for rotator control here: https://github.com/dh1tw/remoteRotator They have some JS components that look like they would make a great web UI for rotator control, and...

Here's what I'm thinking: - Receiver should probably be split into a Transceiver parent object with common cells, a Receiver child object with a demodulator, and a Transmitter child object...

> There's some overdue core refactoring #111 that I want to get in before adding any major features like transmit support that might lock in the current architecture more. (Basically,...

I wrote a rigctld implementation in Python at https://github.com/w1xm/gnuradio/blob/master/dsheen/ssb_transceiver/rigctld.py that you might be able to use as a starting point. (It controls a GRC flowgraph, not ShinySDR, but that's abstracted...

I would prefer not to have lazy initialization of devices; I've seen many drivers that are flaky when opening or reopening the device, and I would very much like the...

Yeah. It sounded from your discussion of "these are explicitly active sinks" that any devices that weren't a dependency would be closed. Something needs to intentionally keep the devices open...

> General early comments: > > * Could you explain why `nodeIdCompat` is necessary? I would rather not give up using actual URLs and cram everything including tests into the...

You can look at https://github.com/w1xm/shinysdr/tree/rotator-tune-shim to see what this would look like using `shim` instead of `nodeIdCompat`.

> My computer(s) are a bit in disarray right now, so I may be a while giving this a proper code review. So, thanks for doing this, and I'll give...