ngx-openlayers icon indicating copy to clipboard operation
ngx-openlayers copied to clipboard

[Question] Migration to Angular 6

Open davinkevin opened this issue 6 years ago • 15 comments

Hi,

Due to the migration to Angular6, I would like to ask to everyone here what version you think we should publish ( #170 ) :

  • 0.9.X
  • 1.X.X
  • 6.X.X
  • Another idea
  • Obiwan Kenobi

Thanks

davinkevin avatar Jun 08 '18 15:06 davinkevin

I think that the lib is mature enought to have its first major release. Angular 6 integration is a good justification to have 1.X.X version;

Yakoust avatar Jun 08 '18 15:06 Yakoust

This version is aimed at being used on prod for us at some point, so I would dismiss 0.9.X. I don't see any point in following Angular with a 6.X.X since we're probably not going to upgrade with every version of Angular. So : 1.X.X

fttriquet avatar Jun 11 '18 07:06 fttriquet

version: 1.X.X release name: galactic unicorn

ghost avatar Jun 11 '18 08:06 ghost

Do we have any major bugs and or any features missing to delay first major release? If not 1.X.X (as said above I don't see a point following angular version number)

aymeric-duchein avatar Jun 11 '18 08:06 aymeric-duchein

My proposition is to split the library into two distinct versions :

  • the latest release which is the 0.8.21 pointing on master branch
  • the next release which is the 1.0.0-next.x pointing on next branch

This trick could be achieved using NPM dist-tags, the current version of the library could be installed as before using npm i ngx-openlayers or you could install the next version using npm i ngx-openlayers@next if you targets the ng6 version for your project.

When the 1.0.0-next.x will be enough stable, documented and fully covered with unit tests, we could publish it as official 1.0.0 version. The major contraint of this is to systematically report each MR in both versions.

Here is my 2 cents.

Neonox31 avatar Jun 12 '18 06:06 Neonox31

@quentin-ol and others, what do you think about the @Neonox31 proposition?

davinkevin avatar Jun 27 '18 04:06 davinkevin

I think the solution of a version 1.0.0 with at least what exposed @Neonox31 could be the best solution. To all, we will close the question this weekend, so if you want to share your opinion, you don't have a lot of time.

davinkevin avatar Jul 10 '18 10:07 davinkevin

I am in favor of @Neonox31 's proposal. The current architecture of the library is very Angular/webpack unfriendly and the sooner a useable modular version there is, the better.

achimha avatar Jul 10 '18 10:07 achimha

Also in favor of @Neonox31 's proposal. A quick comment on 6.x.x: trying to follow Angular version number is difficult and won't reflect the evolution of the lib: not in favor of this.

quentin-ol avatar Jul 10 '18 12:07 quentin-ol

+1 for @Neonox31 's proposal with master and next branches

samuel-girard avatar Aug 02 '18 11:08 samuel-girard

Do we know the release date for compatibility with angular 6?

tolvaly avatar Sep 04 '18 07:09 tolvaly

Unfortunately there is no defined date. The release is now depending on me, I work on the continuous integration chain to work both with ng5 and ng6 versions. Don't worry, the job is nearly done :+1:

Neonox31 avatar Sep 05 '18 18:09 Neonox31

OK, thank you for the details provided. I just came around this library yesterday, and I'm eager to try it out in our current application (we use angular6).

tolvaly avatar Sep 06 '18 10:09 tolvaly

:tada: Thanks to @Neonox31 ngx-openlayers 1.0.0.next.0 is available :tada:

Yakoust avatar Sep 25 '18 13:09 Yakoust

Thanks to all contributors 😘

Neonox31 avatar Sep 25 '18 17:09 Neonox31