uBlock-Origin-dev-filter icon indicating copy to clipboard operation
uBlock-Origin-dev-filter copied to clipboard

google/global.txt: Can sometimes freak out on Google Images

Open brian6932 opened this issue 1 year ago • 5 comments

Eats every result, regardless of them being spam or not.

brian6932 avatar Apr 20 '24 02:04 brian6932

This issue occurs for me as well on a variety of searches.

With the search query "memtest menu" in private browsing, every image result gets eaten for me. Illustrating screenshot

I've tested that with every other filter disabled and only "uBlock-Origin-dev-filter – Google+DuckDuckGo – Global" enabled, the results get eaten; with "uBlock-Origin-dev-filter – Google+DuckDuckGo – Global" disabled, the results do not get eaten.

chuahou avatar May 05 '24 13:05 chuahou

It appears the problem is that the filter list selects the .MjjYud element. On the normal search results page, each .MjjYud corresponds to a single search result, which makes it work perfectly. On the image search results page, however, all the search results are wrapped in a .MjjYud, meaning every result gets eaten if at least one result matches one of the blacklisted domains.

chuahou avatar Jun 06 '24 01:06 chuahou

I've found a fix that seems to work for now, although it allows image results to surface from the site you want to blacklist.

I replaced :upwards(.MjjYud) in the filter with :upwards(.Ww4FFb).

So for example, to block Google results from example.com, you'd use google.com###rso .MjjYud a[href*="example.com"]:upward(.Ww4FFb).

JoshuaZacek avatar Aug 27 '24 15:08 JoshuaZacek