Quelea icon indicating copy to clipboard operation
Quelea copied to clipboard

Clear Button in Light Theme

Open HeyITGuyFixIt opened this issue 4 years ago • 4 comments

The Clear button in the light theme is difficult to see. To make it more visible, I would recommend adding a darker/thicker border.

HeyITGuyFixIt avatar Nov 29 '20 16:11 HeyITGuyFixIt

I agree that it's hard to see the clear button. But I also feel that it's not entirely self-explanatory what it does, so my suggestion would be that we update the icon to something else.

Here are two concept ideas that I was thinking of. What do you think, @berry120, should we take a look at changing the clear icon to something else?

clear-new1 clear-preview1

clear-new2 clear-preview2

ArvidNy avatar Dec 14 '20 20:12 ArvidNy

@ArvidNy What about the first icon, but colours inverted? White on black is probably closer to most setups anyway, and should look fine in both the light and dark theme?

berry120 avatar Dec 16 '20 20:12 berry120

Sure, I just went with black on white to make it closer to the original button and make it different from the black button.

We can of course experiment with how much the letters should fade out, but here's a quick look at what it could look like if it's inverted.

clear-new1b2

new-clear-light new-clear-dark

ArvidNy avatar Dec 16 '20 21:12 ArvidNy

I really like that, certainly as a concept - looks great!

On Wed, 16 Dec 2020 at 21:59, Arvid Nyström [email protected] wrote:

Sure, I just went with black on white to make it closer to the original button and make it different from the black button.

We can of course experiment with how much the letters should fade out, but here's a quick look at what it could look like if it's inverted.

[image: clear-new1b2] https://user-images.githubusercontent.com/14236185/102410977-95555d80-3ff1-11eb-9f2d-2c6f969387dd.png

[image: new-clear-light] https://user-images.githubusercontent.com/14236185/102410836-6808af80-3ff1-11eb-821b-40260dde4918.png

[image: new-clear-dark] https://user-images.githubusercontent.com/14236185/102410831-66d78280-3ff1-11eb-92bf-0757885f84c5.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/quelea-projection/Quelea/issues/311#issuecomment-747066101, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZ6JDP6QWAJQQOC5XVDQADSVEUSNANCNFSM4UGTSDIA .

-- Thanks,

Michael

berry120 avatar Dec 16 '20 22:12 berry120

Hello, I've taken @ArvidNy's icon suggestion and replaced the logo - see #588.

Feedback appreciated :smile: .

joncojonathan avatar Oct 20 '22 21:10 joncojonathan