undergarden icon indicating copy to clipboard operation
undergarden copied to clipboard

Enhance compatibility of entity bucket

Open cech12 opened this issue 2 years ago • 2 comments

I am the developer of the mod Ceramic Bucket. I decided to develop a library mod (BucketLib) to make it easier for mod developers to add own buckets.

To make your mod compatible with my library mod but also to be compatible with other mods I split your bucket content texture (Gwibling) from the underlying bucket to make it reusable. (I did not change it ;D)

You can test the compatibility when you install Ceramic Bucket and BucketLib (at least version 1.18.1-0.5.0.0)

See also the Developer Guide to be compatible in the future. :)

cech12 avatar Jun 01 '22 15:06 cech12

https://github.com/cech12/The-Undergarden/pull/1 Why redistribute bucket texture when you can just refer to in game files instead?

Xaidee avatar Jun 02 '22 02:06 Xaidee

There is no lower bucket texture in the game. Only the normal bucket texture which is one pixel too high. Please compare Tropical Fish Bucket with the empty or water bucket. The empty and water bucket textures are one pixel higher than the textures of entity buckets. If you can show me how to use the vanilla empty bucket and move it one pixel lower, than I would use it.

cech12 avatar Jun 02 '22 05:06 cech12

Is there a plan to merge this PR? :)

cech12 avatar Sep 20 '22 05:09 cech12