resize-observer-polyfill icon indicating copy to clipboard operation
resize-observer-polyfill copied to clipboard

Published 20 hours ago • verified publisher icon que-etc

use getClientRects for IE10+ clientWidth/Height calculation

Open jonirrings opened this issue 2 years ago • 11 comments

a quick fix for the bug mentioned in https://github.com/que-etc/resize-observer-polyfill/issues/2

jonirrings avatar May 11 '22 07:05 jonirrings

getClientRects does not support in ie8-.

yoyo837 avatar May 11 '22 07:05 yoyo837

@yoyo837 emmm, so let's add an API detection? or just deprecate those before IE11 ?

jonirrings avatar May 11 '22 07:05 jonirrings

This is a polyfill, I think it should be an polyfill for all browsers that which version who need it.

yoyo837 avatar May 11 '22 08:05 yoyo837

agreed, old code restored. new code only works when getClientRects available.

jonirrings avatar May 11 '22 08:05 jonirrings

By the way, the maintainer of this repo doesn't seem to be active.

yoyo837 avatar May 11 '22 08:05 yoyo837

sigh…… waiting for him to reply

jonirrings avatar May 11 '22 08:05 jonirrings

@que-etc @TrySound @hashplus @weswigham

ikonan avatar Jun 14 '22 02:06 ikonan

...?

weswigham avatar Jun 14 '22 04:06 weswigham

@weswigham as stated above, can you help to review this pr?

jonirrings avatar Jun 14 '22 06:06 jonirrings

I'm just someone who contributed a PR once in the past, not a maintainer.

weswigham avatar Jun 14 '22 06:06 weswigham

@weswigham whatever, thx for your attention. Waiting for the maintainer ....

jonirrings avatar Jun 14 '22 07:06 jonirrings