quay-operator icon indicating copy to clipboard operation
quay-operator copied to clipboard

Resource configuration for internal database deployments incorrect

Open Maximilian-Pfau-P opened this issue 2 years ago • 2 comments

Hi, the following deployments only have requests specified, no limits: registry-clair-postgres registry-quay-database

This leads to following error in OpenShift: Pod "..." is invalid: spec.containers[0].resources.requests: Invalid value: "2Gi": must be less than or equal to memory limit

An option would be to only specify limits (instead of only specifiing requests). Then OpenShift automatically add requests with the same value as the specified limits.

Could you please change this?

Maximilian-Pfau-P avatar Jul 20 '23 10:07 Maximilian-Pfau-P

Hm, I just tried it with the 3.8.10 operator on OCP 4.13 and it doesn't raise this issue. The Deployment just has resource request for CPU and RAM, but no limits and that should suffice. Can you post your generated resources including status blocks as well as QuayRegistry setting?

dmesser avatar Jul 24 '23 10:07 dmesser

Your right, sorry for that. The LimitRange automatically assigned a resource limit which was causing the error.

Nevertheless it would be beneficial to have a Resource Limit in place as well. Are there reasons why they are not configured per default?

Maximilian-Pfau-P avatar Jul 25 '23 08:07 Maximilian-Pfau-P