claircore icon indicating copy to clipboard operation
claircore copied to clipboard

urn: add URN parser and helpers

Open hdonnay opened this issue 2 years ago • 2 comments

This sets up some support infrastructure to unify naming across claircore. The goal is to be able to pass around names as strings instead of interface objects.

I'm unsure about the Name type -- thoughts on if that should live here and if it should get a method on URN?

hdonnay avatar Apr 16 '24 15:04 hdonnay

Codecov Report

Attention: Patch coverage is 90.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 56.01%. Comparing base (e8f9aff) to head (e26ece1).

Files Patch % Lines
toolkit/urn/urn.go 87.32% 5 Missing and 4 partials :warning:
toolkit/urn/escape.go 92.59% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1323      +/-   ##
==========================================
+ Coverage   55.76%   56.01%   +0.24%     
==========================================
  Files         265      268       +3     
  Lines       16562    16672     +110     
==========================================
+ Hits         9236     9339     +103     
- Misses       6365     6369       +4     
- Partials      961      964       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 16 '24 15:04 codecov[bot]

Re-drafting this until I figure out what to do about percent-encoding.

hdonnay avatar Apr 16 '24 21:04 hdonnay