quasar icon indicating copy to clipboard operation
quasar copied to clipboard
verified publisher icon quasarframework

fix(ui): use correct list type for QSliderSlots (fix: #17060)

Open thexeos opened this issue 1 year ago • 1 comments

What kind of change does this PR introduce?

  • [X] Bugfix

Does this PR introduce a breaking change?

  • [X] No

The PR fulfills these requirements:

  • [X] It's submitted to the dev branch (or v[X] branch)
  • [X] When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)

This fixes #17060

thexeos avatar Mar 30 '24 01:03 thexeos

Build Results

JSON API

📜 Changes detected:

diff --git a/./current-build/api/QRange.json b/./pr-build/api/QRange.json
index 15e8dba..56d1c60 100644
--- a/./current-build/api/QRange.json
+++ b/./pr-build/api/QRange.json
@@ -555,7 +555,7 @@
         },
         "markerList": {
           "type": "Array",
-          "tsType": "SliderMarkerLabelArrayConfig",
+          "tsType": "SliderMarkerLabelConfig",
           "desc": "Array of marker label configs",
           "definition": {
             "index": {
@@ -654,7 +654,7 @@
       "scope": {
         "markerList": {
           "type": "Array",
-          "tsType": "SliderMarkerLabelArrayConfig",
+          "tsType": "SliderMarkerLabelConfig",
           "desc": "Array of marker label configs",
           "definition": {
             "index": {
diff --git a/./current-build/api/QSlider.json b/./pr-build/api/QSlider.json
index b672eea..e4393f9 100644
--- a/./current-build/api/QSlider.json
+++ b/./pr-build/api/QSlider.json
@@ -450,7 +450,7 @@
         },
         "markerList": {
           "type": "Array",
-          "tsType": "SliderMarkerLabelArrayConfig",
+          "tsType": "SliderMarkerLabelConfig",
           "desc": "Array of marker label configs",
           "definition": {
             "index": {
@@ -549,7 +549,7 @@
       "scope": {
         "markerList": {
           "type": "Array",
-          "tsType": "SliderMarkerLabelArrayConfig",
+          "tsType": "SliderMarkerLabelConfig",
           "desc": "Array of marker label configs",
           "definition": {
             "index": {

Types

📜 Changes detected:

diff --git a/./current-build/types/index.d.ts b/./pr-build/types/index.d.ts
index fcc4fb0..ab06fc4 100644
--- a/./current-build/types/index.d.ts
+++ b/./pr-build/types/index.d.ts
@@ -8209,7 +8209,7 @@ export interface QRangeSlots {
     /**
      * Array of marker label configs
      */
-    markerList: SliderMarkerLabelArrayConfig[];
+    markerList: SliderMarkerLabelConfig[];
     /**
      * Object with key-value where key is the model and the value is the marker label config
      */
@@ -8233,7 +8233,7 @@ export interface QRangeSlots {
     /**
      * Array of marker label configs
      */
-    markerList: SliderMarkerLabelArrayConfig[];
+    markerList: SliderMarkerLabelConfig[];
     /**
      * Object with key-value where key is the model and the value is the marker label config
      */
@@ -9879,7 +9879,7 @@ export interface QSliderSlots {
     /**
      * Array of marker label configs
      */
-    markerList: SliderMarkerLabelArrayConfig[];
+    markerList: SliderMarkerLabelConfig[];
     /**
      * Object with key-value where key is the model and the value is the marker label config
      */
@@ -9903,7 +9903,7 @@ export interface QSliderSlots {
     /**
      * Array of marker label configs
      */
-    markerList: SliderMarkerLabelArrayConfig[];
+    markerList: SliderMarkerLabelConfig[];
     /**
      * Object with key-value where key is the model and the value is the marker label config
      */
@@ -14591,7 +14591,6 @@ import { QInputNativeElement } from "./api";
 import { QPopupProxyInnerComponent } from "./api";
 import { SliderMarkerLabels } from "./api";
 import { SliderMarkerLabelConfig } from "./api";
-import { SliderMarkerLabelArrayConfig } from "./api";
 import { SliderMarkerLabelObjectConfig } from "./api";
 import { QTreeNode } from "./api";
 import { QUploaderFactoryFn } from "./api";

github-actions[bot] avatar Mar 30 '24 01:03 github-actions[bot]

Build Results

JSON API

📜 Changes detected:

diff --git a/./current-build/api/QRange.json b/./pr-build/api/QRange.json
index ff50db4..5067ca5 100644
--- a/./current-build/api/QRange.json
+++ b/./pr-build/api/QRange.json
@@ -556,7 +556,7 @@
         },
         "markerList": {
           "type": "Array",
-          "tsType": "SliderMarkerLabelArrayConfig",
+          "tsType": "SliderMarkerLabelConfig",
           "desc": "Array of marker label configs",
           "definition": {
             "index": {
@@ -655,7 +655,7 @@
       "scope": {
         "markerList": {
           "type": "Array",
-          "tsType": "SliderMarkerLabelArrayConfig",
+          "tsType": "SliderMarkerLabelConfig",
           "desc": "Array of marker label configs",
           "definition": {
             "index": {
diff --git a/./current-build/api/QSlider.json b/./pr-build/api/QSlider.json
index 54302d0..b8530e1 100644
--- a/./current-build/api/QSlider.json
+++ b/./pr-build/api/QSlider.json
@@ -451,7 +451,7 @@
         },
         "markerList": {
           "type": "Array",
-          "tsType": "SliderMarkerLabelArrayConfig",
+          "tsType": "SliderMarkerLabelConfig",
           "desc": "Array of marker label configs",
           "definition": {
             "index": {
@@ -550,7 +550,7 @@
       "scope": {
         "markerList": {
           "type": "Array",
-          "tsType": "SliderMarkerLabelArrayConfig",
+          "tsType": "SliderMarkerLabelConfig",
           "desc": "Array of marker label configs",
           "definition": {
             "index": {

Types

📜 Changes detected:

diff --git a/./current-build/types/api/slider.d.ts b/./pr-build/types/api/slider.d.ts
index be31a06..0c1c530 100644
--- a/./current-build/types/api/slider.d.ts
+++ b/./pr-build/types/api/slider.d.ts
@@ -40,8 +40,6 @@ export type SliderMarkerLabelConfig = {
   style: VueStyleObjectProp;
 };
 
-export type SliderMarkerLabelArrayConfig = SliderMarkerLabelConfig[];
-
 export interface SliderMarkerLabelObjectConfig {
   [value: number]: SliderMarkerLabelConfig;
 }
diff --git a/./current-build/types/index.d.ts b/./pr-build/types/index.d.ts
index a084b57..89bd1ab 100644
--- a/./current-build/types/index.d.ts
+++ b/./pr-build/types/index.d.ts
@@ -10078,7 +10078,7 @@ export interface QRangeSlots {
     /**
      * Array of marker label configs
      */
-    markerList: SliderMarkerLabelArrayConfig[];
+    markerList: SliderMarkerLabelConfig[];
     /**
      * Object with key-value where key is the model and the value is the marker label config
      */
@@ -10102,7 +10102,7 @@ export interface QRangeSlots {
     /**
      * Array of marker label configs
      */
-    markerList: SliderMarkerLabelArrayConfig[];
+    markerList: SliderMarkerLabelConfig[];
     /**
      * Object with key-value where key is the model and the value is the marker label config
      */
@@ -11764,7 +11764,7 @@ export interface QSliderSlots {
     /**
      * Array of marker label configs
      */
-    markerList: SliderMarkerLabelArrayConfig[];
+    markerList: SliderMarkerLabelConfig[];
     /**
      * Object with key-value where key is the model and the value is the marker label config
      */
@@ -11788,7 +11788,7 @@ export interface QSliderSlots {
     /**
      * Array of marker label configs
      */
-    markerList: SliderMarkerLabelArrayConfig[];
+    markerList: SliderMarkerLabelConfig[];
     /**
      * Object with key-value where key is the model and the value is the marker label config
      */
@@ -16504,7 +16504,6 @@ import { QInputNativeElement } from "./api";
 import { QPopupProxyInnerComponent } from "./api";
 import { SliderMarkerLabels } from "./api";
 import { SliderMarkerLabelConfig } from "./api";
-import { SliderMarkerLabelArrayConfig } from "./api";
 import { SliderMarkerLabelObjectConfig } from "./api";
 import { QTreeNode } from "./api";
 import { QUploaderFactoryFn } from "./api";

github-actions[bot] avatar Jun 05 '24 14:06 github-actions[bot]