quasar icon indicating copy to clipboard operation
quasar copied to clipboard

QEditor definitions prop type

Open cirolosapio opened this issue 3 years ago • 1 comments

What happened?

QEditorProps interface is defined as:

export interface QEditorProps {
  ...
  definitions?:
    | {
        /**
         * Label of the button
         */
        label?: string;
        /**
         * Text to be displayed as a tooltip on hover
         */
        tip?: string
  ...

What did you expect to happen?

the definitions prop should be Record<string, { ... }>

Reproduction URL

https://stackblitz.com/edit/vitejs-vite-po3wz7?file=src%2Fcomponents%2FTestComp.ts

How to reproduce?

  1. Go to the provided reproduction link
  2. See type error on definitions computed

Flavour

Quasar CLI with Vite (@quasar/cli | @quasar/app-vite)

Areas

Components (quasar), TypeScript Support

Platforms/Browsers

No response

Quasar info output

No response

Relevant log output

No response

Additional context

No response

cirolosapio avatar Aug 05 '22 09:08 cirolosapio

Thank you for reporting this. This is probably the last one of the type errors. It was annoying me for a while, but couldn't find the right time and kept forgetting to open a ticket or fix it.

yusufkandemir avatar Aug 05 '22 12:08 yusufkandemir

i want to contribute but can't find those files can you please tell me where are they?

cirolosapio avatar Aug 12 '22 08:08 cirolosapio

@heartbeatLV https://github.com/quasarframework/quasar/blob/efdff8b2191032fce93319e303a794b1478b3fe8/ui/src/components/editor/QEditor.json#L72-L150

yusufkandemir avatar Aug 12 '22 08:08 yusufkandemir

Enhancement will be available in Quasar 2.8.0

rstoenescu avatar Aug 20 '22 16:08 rstoenescu