quasar-template-default icon indicating copy to clipboard operation
quasar-template-default copied to clipboard

Should not purify 'bg-*' and 'text-*' classes

Open sebastienroul opened this issue 6 years ago • 0 comments

Using variables in some ways to set the color (or bg-color) is not reconized by purifycss even if they try to thing the more crazy things [https://github.com/purifycss/purifycss#detecting-the-use-of-button-active-1] So, always adding colors in the final packaging could be great for dev more crazy than puryfyccss's team :o) or people using color as functional feature....

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [x] It's submitted to the dev branch and not the master branch
  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • [ ] It's been tested with all Quasar themes
  • [ ] It's been tested on a Cordova (iOS, Android) app
  • [ ] It's been tested on a Electron app
  • [ ] Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

sebastienroul avatar Oct 08 '17 21:10 sebastienroul