quasar-template-default icon indicating copy to clipboard operation
quasar-template-default copied to clipboard

Adds docker-compose to quasar default template.

Open codingfriend1 opened this issue 7 years ago • 6 comments

Adds an optional ability to develop your app in a docker container using the default 8080 port. quasar dev --play isn't working in this configuration, you must manually add your computers ip port in the play app. Some people prefer to do their development in containers to keep things isolated and portable, so other developers running the project don't have to install cordova, quasar-cli, or node.

NOTE: This is not a final pull request, this is a sample

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] It's submitted to the dev branch and not the master branch
  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • [ ] It's been tested with all Quasar themes
  • [ ] It's been tested on a Cordova (iOS, Android) app
  • [ ] It's been tested on a Electron app
  • [x] Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • [x] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

codingfriend1 avatar Aug 20 '17 21:08 codingfriend1

Have you seen this?

https://github.com/quasarframework/quasar-docker

Which reminds me, I need to update the containers now that 0.14 is out of beta.

Scott

smolinari avatar Aug 21 '17 12:08 smolinari

Cool, didn't see this! Thanks for sharing!

codingfriend1 avatar Aug 21 '17 15:08 codingfriend1

@smolinari what happened to https://github.com/quasarframework/quasar-docker I am trying to set up something similar without success. It would be really useful to review what you had in that repository.

lkiii avatar Sep 12 '18 17:09 lkiii

@lkiii - The docker stuff has been put on the back burner. I need to speak to Razvan about it, but I'd personally like to get it going again for 1.0, which is planned, I believe at the latest, for the end of the year.

Scott

smolinari avatar Sep 13 '18 08:09 smolinari

@lkiii - The docker stuff has been put on the back burner. I need to speak to Razvan about it, but I'd personally like to get it going again for 1.0, which is planned, I believe at the latest, for the end of the year.

Scott

thank you for the response, maybe I could help with it? I would love to see it working on docker. I had a goal not to install node on my machine only docker, but quasar made me do it.

Also maybe you have a backup of the https://github.com/quasarframework/quasar-docker I would be really happy to look at it.

lkiii avatar Sep 13 '18 14:09 lkiii

@lkiii

Can you get onto Discord? We can PM there about this? For sure we can collaborate. In fact, that would be great!

Scott

smolinari avatar Sep 14 '18 11:09 smolinari