quasar-template-default icon indicating copy to clipboard operation
quasar-template-default copied to clipboard

Published 20 hours ago • verified publisher icon quasarframework

add PWA support with caching

Open sgametrio opened this issue 7 years ago • 2 comments

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] It's submitted to the dev branch and not the master branch
  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • [ ] It's been tested with all Quasar themes
  • [ ] It's been tested on a Cordova (iOS, Android) app
  • [ ] It's been tested on a Electron app
  • [ ] Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information: Add initial PWA support with sw-precache caching of js and css files. In production (only on HTTPS) instantiate a service worker, so the browser can ask you if you want install your app without doing any additional step. The service worker part could be done better but I want to give instant support to ones who want to use PWA in their entirety. Let me know if something isn't working or if I did an hole in the water ;)

sgametrio avatar May 18 '17 20:05 sgametrio

Hi, thank you for this PR.

Can we schedule a talk after the v0.14 release? Currently on a very tight schedule to release the new version, but after that it's time for some new starter kits, and a PWA one is scheduled too. The PWA needs to be another repo entirely as it doesn't makes sense to add this to the default template which can be wrapped by Cordova or Electron too.

So a talk after v0.14?

rstoenescu avatar May 31 '17 06:05 rstoenescu

Sure man. I put this PR here because it is what I am using right now (I don't care about Electron and Cordova so it fits very well on my project). It is a base on what we can do with sw-precache. Let's talk about it after v0.14 release. in the meantime, i will keep it up-to-date here as placeholder

sgametrio avatar May 31 '17 07:05 sgametrio