quasar-starter-kit icon indicating copy to clipboard operation
quasar-starter-kit copied to clipboard

feat: Added noscript notice to index.template.html

Open yusufkandemir opened this issue 6 years ago • 3 comments

What kind of change does this PR introduce?

  • Feature

Does this PR introduce a breaking change?

  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch

Other information: Inspired from Vue CLI.

yusufkandemir avatar Oct 03 '19 14:10 yusufkandemir

Lighthouse checks that there is such a message in PWA so :+1:

sebastien-prudhomme avatar Oct 29 '19 15:10 sebastien-prudhomme

The most recent recommendation has been implemented (current variable used). @IlCallo This useful change looks like it could be merged safely.

Blfrg avatar Sep 20 '20 19:09 Blfrg

@rstoenescu told me there could be problems and left this out on purpose. We'll wait until he can check this and write why it's better to leave it out

IlCallo avatar Sep 21 '20 08:09 IlCallo