quasar icon indicating copy to clipboard operation
quasar copied to clipboard

Bring up to date

Open faddat opened this issue 2 years ago • 3 comments

Every version of the SDK in the 46 series from 0 to 6 has been retracted.

46.0-4: bank module bug 46.4-6 groups issues

We also need to use tendermint 34.26 because It contains a critical peer-to-peer patch.

Main branch needs:

SDK 46.9 Tendermint 34.26 Wasmd v0.30.0 (notional 46 fork) IBC v6 async-icq v6 packet-forward-middleware v6 token factory

Once we have gotten these landed, we should find that we are in a far better place for development. I also suspect that these will resolve the IAVL issue, I believe that most likely the IAVL issue is coming from using various mismatched or old dependencies. A good example of this is the version of IBC that we were using due to the ICQ shim. It wasn't even full v5, it was a release candidate version.

The second good example is WASMD. Our integration work for SDK46 and WASMD did not actually complete until the release of WASMD 29, however this repository is referencing WASMD27.

faddat avatar Feb 09 '23 19:02 faddat

Related work:

  • https://github.com/strangelove-ventures/interchaintest/pull/394
  • https://github.com/quasar-finance/quasar/pull/210
  • https://github.com/quasar-finance/wasmd/pull/1
  • https://github.com/quasar-finance/wasmd/pull/3
  • https://github.com/quasar-finance/wasmd/pull/2
  • https://github.com/bandprotocol/bandchain-packet/pull/5

Notes:

this commit 3d4d7ac of the packet-seq-return branch of quasar/wasmd fails every test.

Was the most recent commit.

github.com/CosmWasm/wasmd/x/wasm/keeper

x/wasm/keeper/handler_plugin.go:198:42: unknown field Sequence in struct literal of type "github.com/cosmos/ibc-go/v5/modules/apps/transfer/types".MsgTransferResponse ? github.com/CosmWasm/wasmd/app/params [no test files] ? github.com/CosmWasm/wasmd/cmd/contract_tests [no test files] ? github.com/CosmWasm/wasmd/third_party/proto/tendermint/blockchain [no test files] FAIL github.com/CosmWasm/wasmd/app [build failed] FAIL github.com/CosmWasm/wasmd/benchmarks [build failed] ? github.com/CosmWasm/wasmd/third_party/proto/tendermint/consensus [no test files] ? github.com/CosmWasm/wasmd/third_party/proto/tendermint/libs/bits [no test files] ? github.com/CosmWasm/wasmd/third_party/proto/tendermint/crypto [no test files] ? github.com/CosmWasm/wasmd/third_party/proto/tendermint/mempool [no test files] ? github.com/CosmWasm/wasmd/third_party/proto/tendermint/p2p [no test files] ? github.com/CosmWasm/wasmd/third_party/proto/tendermint/privval [no test files] ? github.com/CosmWasm/wasmd/third_party/proto/tendermint/state [no test files] ? github.com/CosmWasm/wasmd/third_party/proto/tendermint/statesync [no test files] ? github.com/CosmWasm/wasmd/third_party/proto/tendermint/store [no test files] ? github.com/CosmWasm/wasmd/third_party/proto/tendermint/types [no test files] ? github.com/CosmWasm/wasmd/third_party/proto/tendermint/version [no test files] FAIL github.com/CosmWasm/wasmd/x/wasm [build failed] FAIL github.com/CosmWasm/wasmd/x/wasm/client/cli [build failed] ? github.com/CosmWasm/wasmd/x/wasm/keeper/wasmtesting [no test files] ok github.com/CosmWasm/wasmd/x/wasm/ioutils (cached) FAIL github.com/CosmWasm/wasmd/x/wasm/keeper [build failed] ok github.com/CosmWasm/wasmd/x/wasm/types (cached) FAIL make: *** [test-unit] Error 1

faddat avatar Feb 10 '23 05:02 faddat

ibc-go in quasar and ibc-go in wasmd are differentially versioned because of quasar's support for icq. Trying to prepare an updated branch.

faddat avatar Feb 10 '23 06:02 faddat

Updated icq succeeded, and is a tagged release of:

github.com/notional-labs/ibc-go v5.2.0-icq

faddat avatar Feb 10 '23 06:02 faddat