quary icon indicating copy to clipboard operation
quary copied to clipboard

[BUG] Build fails in duckdb

Open yurivict opened this issue 1 year ago • 2 comments

Current Behavior:

Build fails because it somehow can't find :

[libduckdb-sys 1.0.0] cargo:warning=/wrkdirs/usr/ports/misc/quary/work/target/release/build/libduckdb-sys-5a87e5a46b16f13e/out/duckdb/third_party/libpg_query/include/pg_functions.hpp:4:10: fatal error: 'string' file not found
[libduckdb-sys 1.0.0] cargo:warning=    4 | #include <string>
[libduckdb-sys 1.0.0] cargo:warning=      |          ^~~~~~~~
[libduckdb-sys 1.0.0] cargo:warning=1 error generated.  
[libduckdb-sys 1.0.0] exit status: 1

log

There's really no nee to rebuild duckdb because we have a separate duckdb package that passes 100% of tests. How to use the external duckdb package?

Steps To Reproduce:

Regular build.

Environment:

  • Version: 0.7.0
  • rust-nightly-1.83.0.20241001
  • OS: FreeBSD 14.1

Anything else:

The version 0.3.2 was building fine.

yurivict avatar Nov 02 '24 04:11 yurivict

If we remove features = ["bundled"], will it start building? Ideally, it should then link dynamically and use the existing duckdb package. https://github.com/quarylabs/quary/blob/cb2bb7345fdbba880a8ec5db11c2b59fb5049bc3/rust/quary-databases/Cargo.toml#L27

gvozdvmozgu avatar Nov 02 '24 15:11 gvozdvmozgu

@gvozdvmozgu I confirm that it builds fine with "bundled" removed.

yurivict avatar Nov 02 '24 20:11 yurivict