stabilizer icon indicating copy to clipboard operation
stabilizer copied to clipboard

Updating `menu` version to combine context and interface

Open ryan-summers opened this issue 1 year ago • 2 comments

This PR updates the version of menu used to have a single context that uses the embedded-io traits and is writable.

This PR was done to understand if the context and interface of menu could be combined.

The main downside observed is that the Settings structure isn't carried around as a top-level resource, but is hidden behind a few layers of indirection because of the necessary lifetime borrow abstractions.

ryan-summers avatar Apr 08 '24 10:04 ryan-summers

I would say we leave the current implementation as-is and wait and see what direction menu ends up going. If it gets released to crates.io in this state, we can merge this PR and port over, but there's no burning need to at this point unless we want to publish serial-settings (which I don't think is stable enough to publish yet).

ryan-summers avatar Apr 08 '24 12:04 ryan-summers

Agreed.

jordens avatar Apr 08 '24 12:04 jordens

This version of menu did not end up being merged, Instead, the code currently in the repo is closer. As such, I'm closing this PR as this work is no longer required.

ryan-summers avatar Apr 29 '24 10:04 ryan-summers