quarkusio.github.io icon indicating copy to clipboard operation
quarkusio.github.io copied to clipboard
verified publisher icon quarkusio

Performance page

Open insectengine opened this issue 1 year ago • 3 comments

  1. Add new performance page
  2. Add to index page (re-org features band)
  3. Add performance page to primary navigation (re-org navigation)
  4. Add link to continuum page (Reactive) to the primary navigation

@holly-cummins

insectengine avatar Sep 20 '24 21:09 insectengine

🙈 The PR is closed and the preview is expired.

github-actions[bot] avatar Sep 20 '24 21:09 github-actions[bot]

+1 to having this page, but I made some suggestions on Jeff Beck's google document that it would be nice to see incorporated here. The version on this PR doesn't mention our excellent throughput, which we need to start talking about.

holly-cummins avatar Sep 23 '24 10:09 holly-cummins

@holly-cummins - please check this out again as I've updated the content.

insectengine avatar Sep 23 '24 22:09 insectengine

Looks good to me, thanks! :)

I'm looking forward to using that throughput icon in other places, too.

holly-cummins avatar Sep 25 '24 19:09 holly-cummins

I'd add an approving review but I don't have the permissions to assign reviewers.

holly-cummins avatar Sep 25 '24 19:09 holly-cummins

I added some reviews.

insectengine avatar Sep 25 '24 20:09 insectengine

I feel this is ready for review... 1) Home Page - Updated the "features" band to "benefits" and added the Performance icon/text https://quarkus-site-pr-2122-preview.surge.sh/

2) Performance Page - Updated content from the doc. https://quarkus-site-pr-2122-preview.surge.sh/performance/

3) Flyout Nav - Added to the "Why" flyout

insectengine avatar Oct 24 '24 22:10 insectengine

Where are we with this, @cescoffier? It would be fantastic to get this reviewed and up so we can start getting eyeballs on this important content.

holly-cummins avatar Nov 12 '24 21:11 holly-cummins

@holly-cummins @insectengine Hey! Sorry, missed the last update. It looks A LOT better. I will do a few suggestion later today:

  • @holly-cummins, don't we have an image for the introduction? I preferred ending the paragraph with the Why
  • The is the weird (or absence of) transition in the reactive core section
  • The high throughput paragraph does not talk about high throughput per se.

cescoffier avatar Nov 13 '24 07:11 cescoffier

@cescoffier, it looks like your suggested changes are now live at https://quarkus-site-pr-2122-preview.surge.sh/performance/

holly-cummins avatar Nov 14 '24 11:11 holly-cummins

@holly-cummins not the landing page (order + outdated content).

Maybe we can limit this PR to the performance page.

cescoffier avatar Nov 14 '24 11:11 cescoffier

@insectengine Thanks for the update, waiting for the previous (because, no... I'm not reviewing HTML blurb :-))

cescoffier avatar Nov 14 '24 15:11 cescoffier

@insectengine The content on the landing page is outdated:

That's what we have on quarkus.io: image

cescoffier avatar Nov 14 '24 17:11 cescoffier

@cescoffier - updated the Reactive title/content for the homepage.

insectengine avatar Nov 14 '24 17:11 insectengine

LGTM, @holly-cummins Are you ok?

@insectengine maybe squash the commits. 12 commits, that's a bit too much :-)

cescoffier avatar Nov 14 '24 17:11 cescoffier

Yes, squash and go, I think!

holly-cummins avatar Nov 14 '24 17:11 holly-cummins

@cescoffier - A merge commit blocked any squashing I tried to do. I pulled the changed files into a new branch and submitted a new PR for the Performance page.

https://github.com/quarkusio/quarkusio.github.io/pull/2163

insectengine avatar Nov 14 '24 21:11 insectengine