quarkusio.github.io icon indicating copy to clipboard operation
quarkusio.github.io copied to clipboard

Published 20 hours ago • verified publisher icon quarkusio

Add edit-this-page link

Open marcelstoer opened this issue 1 year ago • 13 comments

This started at https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/.E2.9C.94.20How.20does.20Quarkus.20find.20the.20deployment.20JAR.20of.20an.20extension.3F/near/416737768

@maxandersen

marcelstoer avatar Jan 19 '24 21:01 marcelstoer

🙈 The PR is closed and the preview is expired.

github-actions[bot] avatar Jan 22 '24 13:01 github-actions[bot]

This is a great idea but there is an issue with the placement as it breaks the blue bar on mobile. Additionally, it would make more sense contextually for it to be on the white, content area of the page. Also, adding the "edit" icon from Font Awesome will help the users better understand the links purpose when quick scanning.

editpage_relocated

insectengine avatar Jan 30 '24 21:01 insectengine

@insectengine Thanks, I agree. Do you maybe have some HTML/CSS from your mock-up that I could reuse?

marcelstoer avatar Jan 30 '24 21:01 marcelstoer

I just tried to send a commit to this PR with my html/CSS. Please let me know if it doesn't work.

insectengine avatar Jan 30 '24 22:01 insectengine

Which way did you do that? GitHub doesn't seem to have recorded anything.

marcelstoer avatar Jan 30 '24 22:01 marcelstoer

Can you see this PR? https://github.com/marcelstoer/quarkusio.github.io/pull/1

insectengine avatar Jan 31 '24 13:01 insectengine

This last commit has it: https://github.com/marcelstoer/quarkusio.github.io/commit/9cc4db67841eb1895bb59302b9dacdd501654bee

@insectengine your pr includes alot of additional changes.

maxandersen avatar Jan 31 '24 17:01 maxandersen

Thanks, I cleaned up the PR. Sorry @insectengine, GitHub hadn't notified me about your PR towards my branch.

Screenshot 2024-01-31 at 21 16 01

marcelstoer avatar Jan 31 '24 20:01 marcelstoer

Sorry about that. I thought I only checked in the bar minimum.

insectengine avatar Jan 31 '24 20:01 insectengine

@maxandersen Anything still missing here?

marcelstoer avatar Feb 08 '24 09:02 marcelstoer

How can I tell the bot to deploy the latest version to surge.sh like when I pushed the initial version?

marcelstoer avatar Apr 10 '24 14:04 marcelstoer

How can I tell the bot to deploy the latest version to surge.sh like when I pushed the initial version?

It should run GitHub actions and do a surge deploy for each push, but it only comments once (the URL stays the same).

holly-cummins avatar Apr 10 '24 15:04 holly-cummins

Thanks, I had checked the actions but didn't spot the surge deployment. Also, I had opened the preview URL but now realized I need to force-reload the site to bust its cache.

Screenshot 2024-04-10 at 17 13 24

Source: https://quarkus-site-pr-1878-preview.surge.sh/guides/telemetry-micrometer-tutorial

marcelstoer avatar Apr 10 '24 15:04 marcelstoer