quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

Published 20 hours ago • verified publisher icon quarkusio

[CI] - Blaze-Persistence + Quarkus main

Open Mobe91 opened this issue 4 years ago • 367 comments

This issue will be open and closed dependent on the state of https://github.com/Blazebit/blaze-persistence building against Quarkus master snapshot.

If you have interest in being notified of this subscribe to the issue.

Mobe91 avatar May 07 '20 06:05 Mobe91

The build is still failing:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/98835682

Mobe91 avatar May 08 '20 05:05 Mobe91

The build is still failing:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/98938628

Mobe91 avatar May 08 '20 08:05 Mobe91

The build is still failing:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/101098955

Mobe91 avatar May 11 '20 05:05 Mobe91

Build fixed:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/101295500

Mobe91 avatar May 11 '20 10:05 Mobe91

Unfortunately, the build failed:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/129386857

Mobe91 avatar Jun 09 '20 05:06 Mobe91

Build fixed:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/129447685

Mobe91 avatar Jun 09 '20 07:06 Mobe91

Unfortunately, the build failed:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/169583915

Mobe91 avatar Jul 15 '20 05:07 Mobe91

Build fixed:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/170095019

Mobe91 avatar Jul 15 '20 14:07 Mobe91

Unfortunately, the build failed:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/232072365

Mobe91 avatar Aug 31 '20 06:08 Mobe91

The build is still failing:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/233769067

Mobe91 avatar Sep 01 '20 05:09 Mobe91

@Mobe91 @beikov apparently the Hibernate ORM upgrade in Quarkus broke Blaze Persistence :/. Looks like you rely on an internal method that has changed.

/cc @Sanne

gsmet avatar Sep 01 '20 06:09 gsmet

That's what I tried to avoid here: https://github.com/hibernate/hibernate-orm/pull/3511#discussion_r479958716

I'm planning to do a release soon anyway, should I incorporate a fix for the new method signature or would you say it's better to revert the IMO unnecessary signature change in Hibernate?

beikov avatar Sep 01 '20 07:09 beikov

My personal opinion is that we should be more cautious in micro releases but, given our Quarkus schedule, I would say this ship has sailed...

If you can adapt and release something before September 10th latest, that would be great.

gsmet avatar Sep 01 '20 07:09 gsmet

I brought the issue up, but since it's internal, the others said the change is fine. I will try to fix this in Blaze-Persistence. Releasing before 10th of September should be doable.

beikov avatar Sep 01 '20 07:09 beikov

Hum. Let me correct that. There's a good chance we will backport this upgrade to the 1.7 branch and thus I would need the Platform upgrade PR by September 8th latest.

Sorry about the confusion.

gsmet avatar Sep 01 '20 08:09 gsmet

I see, I'll try to get that in ASAP then :)

beikov avatar Sep 01 '20 08:09 beikov

Thanks and sorry about the mess.

gsmet avatar Sep 01 '20 08:09 gsmet

thanks @beikov ! And sorry your comment regarding it breaking Blaze came too late on the other thread :)

I'm considering setting up "downstream integration" CI builds for Hibernate ORM, including e.g. Quarkus (but also Search, Hibernate Reactive, etc..).

I wouldn't mind including Blaze as well: it's one thing to break an internal API, it's another to break an integration we actually care about.

Sanne avatar Sep 01 '20 09:09 Sanne

The build is still failing:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/235493018

Mobe91 avatar Sep 02 '20 05:09 Mobe91

The build is still failing:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/237203663

Mobe91 avatar Sep 03 '20 05:09 Mobe91

Build fixed:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/237554965

Mobe91 avatar Sep 03 '20 10:09 Mobe91

Nice! thanks @Mobe91 and @beikov

Sanne avatar Sep 03 '20 10:09 Sanne

Unfortunately, the build failed:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/249242103

Mobe91 avatar Sep 11 '20 05:09 Mobe91

The build is still failing:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/249426674

Mobe91 avatar Sep 11 '20 08:09 Mobe91

Build fixed:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/253225423

Mobe91 avatar Sep 14 '20 05:09 Mobe91

Unfortunately, the build failed:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/342970676

Mobe91 avatar Nov 03 '20 05:11 Mobe91

The build is still failing:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/344888311

Mobe91 avatar Nov 04 '20 05:11 Mobe91

The build is still failing:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/346860487

Mobe91 avatar Nov 05 '20 05:11 Mobe91

The build is still failing:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/348852416

Mobe91 avatar Nov 06 '20 05:11 Mobe91

The build is still failing:

  • Link to latest CI run: https://github.com/Blazebit/blaze-persistence/actions/runs/353227602

Mobe91 avatar Nov 09 '20 05:11 Mobe91