consolidate `spotless-maven-plugin`, `formatter-maven-plugin`, and `impsort-maven-plugin`
-
current stack is not formatting kotlin as not configured, as spotless currently is maverick but more capable of the 2 both existing plugsin which dont cover unused import due to bug:
-
https://github.com/revelc/impsort-maven-plugin/issues/139
-
https://github.com/revelc/formatter-maven-plugin/issues/986
-
https://github.com/quarkusio/quarkus/pull/48397
-
https://github.com/quarkusio/quarkus/pull/48372
-
sportless is already in place and ready to take over
-
kotlin format is not applied.
fix:
- https://github.com/quarkusio/quarkus/blob/6f7b03723d20c9141c5dcd096800c4796ed03806/extensions/websockets-next/deployment/pom.xml#L199
[INFO] Quarkus - Integration Tests - Virtual Threads - JMS SUCCESS [ 0.031 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Vert.x Event Bus SUCCESS [ 0.036 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Scheduler SUCCESS [ 0.039 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Quartz Scheduler SUCCESS [ 0.036 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Disabled SUCCESS [ 0.037 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Reactive Routes SUCCESS [ 0.032 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Security WebAuthn SUCCESS [ 0.031 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Micrometer Metrics SUCCESS [ 0.030 s]
[INFO] Quarkus - Integration Tests - Mutiny native JCTools support SUCCESS [ 0.038 s]
[INFO] Quarkus - Documentation ............................ SUCCESS [ 0.363 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:20 min
[INFO] Finished at: 2025-06-15T17:46:10+02:00
[INFO] ------------------------------------------------------------------------
[INFO] Njord session closed
[INFO] 1296 goals, 1296 executed
[WARNING]
[WARNING] 1 build scan custom value was not captured:
[WARNING] - Maximum custom value value length (100.000) exceeded: Git status
➜ quarkus git:(spot-missing-override) ✗ mvn spotless:apply
/cc @gsmet (elasticsearch), @loicmathieu (elasticsearch), @marko-bekhta (elasticsearch)
Thanks for your pull request!
Your pull request does not follow our editorial rules. Could you have a look?
- title should preferably start with an uppercase character (if it makes sense!)
This message is automatically generated by a bot.
@gsmet @gastaldi please see demo of format delta. spot does interprete the eclipse config differently.
current setup does not fix unused imports due to bug in plugin.
spot covered other two plugins making it 3 for 1 tradeoff as spot is already integrated but not in used, this an cost of carry issue itself.
please lets work together. sorry for overpacing i need to coordinate better. its my hyper activity.
having guidance from you we can leverage this and make the code better.
please see that my suggestions can be used for good. i have no problem of a closed pr. we make better version every time.
its no thing to rush of course.
- https://github.com/spring-projects/spring-framework/pull/35047
- https://github.com/spring-projects/spring-framework/commit/0d4dfb6c1f724f9b9081de58d480856b88e4e416
should it be same version?
if you like then, need to execute local as (almost) EVERYTHING will be changed ONCE, and be fixed, like aimed before, but this time done and dusty.
quarkus dont care