quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

fix grpc method conversion in BlockingServerInterceptor

Open nconcetti opened this issue 6 months ago • 4 comments

This is a try to fix the behaviour described in https://github.com/quarkusio/quarkus/issues/48358.

nconcetti avatar Jun 12 '25 21:06 nconcetti

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

quarkus-bot[bot] avatar Jun 12 '25 21:06 quarkus-bot[bot]


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit eee96e25260bb6a1cf0245fa4da696b0e4578c5c.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Initial JDK 17 Build Build Failures Logs Raw logs :mag:

You can consult the Develocity build scans.

Failures

:gear: Initial JDK 17 Build #

- Failing: extensions/grpc/runtime 
! Skipped: devtools/bom-descriptor-json docs extensions/grpc/deployment and 117 more

:package: extensions/grpc/runtime

Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.26.0:validate (default) on project quarkus-grpc: File '/home/runner/_work/quarkus/quarkus/extensions/grpc/runtime/src/test/java/io/quarkus/grpc/runtime/supports/BlockingServerInterceptorTest.java' has not been previously formatted. Please format file (for example by invoking `mvn -f extensions/grpc/runtime net.revelc.code.formatter:formatter-maven-plugin:2.26.0:format`) and commit before running validation!

quarkus-bot[bot] avatar Jun 13 '25 04:06 quarkus-bot[bot]

Can you squash your commits?

cescoffier avatar Jun 16 '25 06:06 cescoffier

commits are squashed :)

nconcetti avatar Jun 16 '25 11:06 nconcetti


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a7cca9af938f00bcca123dbaa2e840f70a0b1d90.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Initial JDK 17 Build Build Failures Logs Raw logs :mag:

You can consult the Develocity build scans.

Failures

:gear: Initial JDK 17 Build #

- Failing: extensions/grpc/runtime 
! Skipped: devtools/bom-descriptor-json docs extensions/grpc/deployment and 117 more

:package: extensions/grpc/runtime

Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.26.0:validate (default) on project quarkus-grpc: File '/home/runner/_work/quarkus/quarkus/extensions/grpc/runtime/src/main/java/io/quarkus/grpc/runtime/supports/blocking/BlockingServerInterceptor.java' has not been previously formatted. Please format file (for example by invoking `mvn -f extensions/grpc/runtime net.revelc.code.formatter:formatter-maven-plugin:2.26.0:format`) and commit before running validation!

quarkus-bot[bot] avatar Jun 17 '25 15:06 quarkus-bot[bot]

again, fixed code formatting for ci

nconcetti avatar Jun 17 '25 21:06 nconcetti


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 637bfb1f8881efc6c316fcf296132b2b466b50ad.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Native Tests - Data4 Build Failures Logs Raw logs :mag:
Native Tests - Virtual Thread - Main Build :warning: Check → Logs Raw logs :mag:

You can consult the Develocity build scans.

Failures

:gear: Native Tests - Data4 #

- Failing: integration-tests/mongodb-client 

:package: integration-tests/mongodb-client

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-mongodb-client: Failed to build quarkus application


Flaky tests - Develocity

:gear: JVM Integration Tests - JDK 17

:package: integration-tests/opentelemetry

io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

:gear: JVM Integration Tests - JDK 21

:package: integration-tests/opentelemetry

io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

quarkus-bot[bot] avatar Jun 18 '25 05:06 quarkus-bot[bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 637bfb1f8881efc6c316fcf296132b2b466b50ad.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

quarkus-bot[bot] avatar Jun 18 '25 06:06 quarkus-bot[bot]