quarkusio
Unzip zip files in hibernate HBM2DDL_IMPORT_FILES setting
Thanks for your pull request!
Your pull request does not follow our editorial rules. Could you have a look?
- title should not end up with dot
- title should preferably start with an uppercase character (if it makes sense!)
This message is automatically generated by a bot.
![quarkus-bot[bot] avatar](https://avatars.githubusercontent.com/in/90234?v=4 "Published by a pub.dev verified publisher"){kind=small}
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit b90bee27c5c03ad8848397bd156a7941663b38c6.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
[!WARNING] There are other workflow runs running, you probably need to wait for their status before merging.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit b90bee27c5c03ad8848397bd156a7941663b38c6.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
You can consult the Develocity build scans.
Hello @alihmzyv , could you please give me access to push to this repo? I made a small changes
Hello @alihmzyv , could you please give me access to push to this repo? I made a small changes
Hey @kto-viktor. You'd better push to your own fork, and send a new PR from there. People don't usually give push access to their fork to others :)
Hi @kto-viktor. I added you as a collaborator. If you want you can accept it. I actually would be happy if my small contribution would be helpful as well). Thanks
Hey @kto-viktor , I think your rebase went wrong: there are 22 commits in this PR now, most by other people.
Can you please try rebasing and removing commits that shouldn't be here?
Usually this works fine for me:
git switch main
git pull
git switch <my branch>
git rebase -i main
# In the editor, remove lines for commits that shouldn't be there, then save and quit
# Handle conflicts
git push --force
Hey @kto-viktor , I think your rebase went wrong: there are 22 commits in this PR now, most by other people.
Can you please try rebasing and removing commits that shouldn't be here?
Usually this works fine for me:
git switch main git pull git switch <my branch> git rebase -i main # In the editor, remove lines for commits that shouldn't be there, then save and quit # Handle conflicts git push --force
Hello @yrodiere , this helps to remove unwanted commits; but somewhy github showing merge conflict - even, when i merging main locally, it showing up-to-date.. Maybe you have some recommendation?
but somewhy github showing merge conflict - even, when i merging main locally, it showing up-to-date.. Maybe you have some recommendation?
Maybe your local main branch is tracking a fork, instead of tracking the quarkusio/quarkus repository?
See https://stackoverflow.com/a/4693780/6692043 for more information on tracking branches.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit 149d68e5cc8deac06af20b2d0b74f7813c5ec8fa.
Failing Jobs
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | Initial JDK 17 Build | Build |
Failures | Logs | Raw logs | :mag: |
You can consult the Develocity build scans.
Failures
:gear: Initial JDK 17 Build #
- Failing: extensions/hibernate-orm/runtime
! Skipped: devtools/bom-descriptor-json docs extensions/flyway/deployment and 119 more
:package: extensions/hibernate-orm/runtime
✖ Failed to execute goal net.revelc.code:impsort-maven-plugin:1.12.0:check (check-imports) on project quarkus-hibernate-orm: Imports are not sorted in /home/runner/_work/quarkus/quarkus/extensions/hibernate-orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/SchemaToolingUtil.java
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit afe226079f1ef6a307472e424aa9e8953707c85d.
Failing Jobs
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | Initial JDK 17 Build | Build |
Failures | Logs | Raw logs | :mag: |
You can consult the Develocity build scans.
Failures
:gear: Initial JDK 17 Build #
- Failing: extensions/hibernate-orm/runtime
! Skipped: devtools/bom-descriptor-json docs extensions/flyway/deployment and 119 more
:package: extensions/hibernate-orm/runtime
✖ Failed to execute goal de.thetaphi:forbiddenapis:3.4:check (verify-forbidden-apis) on project quarkus-hibernate-orm: Check for forbidden API calls failed, see log.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit afe226079f1ef6a307472e424aa9e8953707c85d.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit 8208e1e5c1aca8e5f201f85d2369cf260e11c71f.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
[!WARNING] There are other workflow runs running, you probably need to wait for their status before merging.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit 8208e1e5c1aca8e5f201f85d2369cf260e11c71f.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
You can consult the Develocity build scans.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit 43b017109f3ffd7163dfd350891bb942cfab468d.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
[!WARNING] There are other workflow runs running, you probably need to wait for their status before merging.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit 43b017109f3ffd7163dfd350891bb942cfab468d.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
You can consult the Develocity build scans.
Flaky tests - Develocity
:gear: JVM Integration Tests - JDK 17 Windows
:package: integration-tests/grpc-hibernate
✖ com.example.grpc.hibernate.VertxBlockingRawTest.shouldAdd - History
Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.-org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
Can you squash all your commits and force-push the single commit to your branch?
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit d41e8f8b807724d29527fec8a7d8419aacee0fc7.
Failing Jobs
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | Documentation Build | Build |
Failures | Logs | Raw logs | :construction: |
Failures
:gear: Documentation Build #
- Failing: extensions/hibernate-orm/runtime
! Skipped: devtools/bom-descriptor-json devtools/cli devtools/config-doc-maven-plugin and 1138 more
:package: extensions/hibernate-orm/runtime
✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile (default-compile) on project quarkus-hibernate-orm: Compilation failure
/home/runner/work/quarkus/quarkus/extensions/hibernate-orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/SchemaToolingUtil.java:[17,47] cannot find symbol
symbol: class ArrayList
location: class io.quarkus.hibernate.orm.runtime.SchemaToolingUtil
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit d41e8f8b807724d29527fec8a7d8419aacee0fc7.
Failing Jobs
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | Initial JDK 17 Build | Build |
Failures | Logs | Raw logs | :mag: |
You can consult the Develocity build scans.
Failures
:gear: Initial JDK 17 Build #
- Failing: extensions/hibernate-orm/runtime
! Skipped: devtools/bom-descriptor-json docs extensions/flyway/deployment and 120 more
:package: extensions/hibernate-orm/runtime
✖ Failed to execute goal net.revelc.code:impsort-maven-plugin:1.12.0:check (check-imports) on project quarkus-hibernate-orm: Imports are not sorted in /home/runner/_work/quarkus/quarkus/extensions/hibernate-orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/SchemaToolingUtil.java
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit b9ebec532dfcaeeed53e4187dff48f045ab7ad74.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
[!WARNING] There are other workflow runs running, you probably need to wait for their status before merging.
Can you squash all your commits and force-push the single commit to your branch?
Hello @gastaldi First thanks for review. Regarding commits, is it possible to push 2 commits? Because this PR we co-authored with @alihmzyv ; and actually there is really 2 modular commits - one for logic of unzipping, one to migrate from deprecated hibernate setting (which also needs for this feature to work)
If it's not allowed, then I will squash to single commit.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit 6f16571230e81478d50904b9efee7508b2b93112.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
[!WARNING] There are other workflow runs running, you probably need to wait for their status before merging.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit 6f16571230e81478d50904b9efee7508b2b93112.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
You can consult the Develocity build scans.
Hello, @gastaldi , looks like @yrodiere is on leave :( i pinged him directly few times
Hello, @gastaldi , looks like @yrodiere is on leave :( i pinged him directly few times
He'll be back soon. otherwise we can ask @gsmet to merge
