quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

Remove OpenTracing

Open radcortez opened this issue 1 year ago • 7 comments

~~Missing the jdbc tracing, that was only deprecated in https://github.com/quarkusio/quarkus/pull/43416~~

Remove remaining references of OpenTracing. See https://github.com/quarkusio/quarkus/pull/43542/

radcortez avatar Oct 18 '24 12:10 radcortez

This needs a rebase

geoand avatar Oct 18 '24 14:10 geoand

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit c2499802362d026f42d2563122f42d98c19b5af0.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

[!WARNING] There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot[bot] avatar Oct 18 '24 15:10 quarkus-bot[bot]

🙈 The PR is closed and the preview is expired.

github-actions[bot] avatar Oct 18 '24 15:10 github-actions[bot]

Let's make sure we add a note in the migration guide for 3.17.

gsmet avatar Oct 18 '24 17:10 gsmet

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c2499802362d026f42d2563122f42d98c19b5af0.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

:gear: JVM Tests - JDK 17 Windows

:package: extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.metrics.HttpServerMetricsTest.collectsHttpRouteFromEndAttributes - History

  • Assertion condition defined as a Lambda expression in io.quarkus.opentelemetry.deployment.common.exporter.InMemoryMetricExporter expected: <true> but was: <false> within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.opentelemetry.deployment.common.exporter.InMemoryMetricExporter expected: <true> but was: <false> within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.opentelemetry.deployment.common.exporter.InMemoryMetricExporter.assertCountPointsAtLeast(InMemoryMetricExporter.java:131)
	at io.quarkus.opentelemetry.deployment.common.exporter.InMemoryMetricExporter_ClientProxy.assertCountPointsAtLeast(Unknown Source)

:package: integration-tests/grpc-hibernate

com.example.grpc.hibernate.VertxBlockingRawTest.shouldAdd - History

  • Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

quarkus-bot[bot] avatar Oct 18 '24 18:10 quarkus-bot[bot]

Let's make sure we add a note in the migration guide for 3.17.

Ok!

radcortez avatar Oct 18 '24 19:10 radcortez

Added this: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.17#opentracing

radcortez avatar Oct 18 '24 20:10 radcortez