quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

Avoid getting the GraalVM version at deployment time for AWT

Open zakkak opened this issue 1 year ago • 6 comments

Reduces the times we start a container when using a builder-image

zakkak avatar Oct 11 '24 13:10 zakkak

/cc @Karm (awt), @galderz (awt)

quarkus-bot[bot] avatar Oct 11 '24 13:10 quarkus-bot[bot]

I'm sorry for the noise, I've just realized this is a draft. I'm gonna wait how it unfolds first.

Btw, testing with runtime container too, which is not a part of the regular GHA here, is a good thing to try with changes:

(locally Java 17)
$ ./mvnw verify -f integration-tests/pom.xml -pl awt -Ddocker -Dnative 
  -Dquarkus.native.container-build=true -Dquarkus.container-image.build=true 
  -Dquarkus.native.builder-image=quay.io/quarkus/ubi-quarkus-mandrel-builder-image:jdk-21 
  -Dquarkus.native.container-runtime=podman 2>&1 | tee log.log

Karm avatar Oct 11 '24 15:10 Karm


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 942c089bd7a2c44c1e333c5bb3c45df2cb6d327f.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

:gear: JVM Tests - JDK 21

:package: extensions/infinispan-cache/deployment

io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls - History

  • expected: "thread1" but was: "thread2" - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: 

expected: "thread1"
 but was: "thread2"
	at io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls(InfinispanCacheTest.java:283)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:427)

:gear: Native Tests - HTTP

:package: integration-tests/rest-client-reactive

io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History

  • expected: <1> but was: <2> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:810)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

quarkus-bot[bot] avatar Oct 15 '24 02:10 quarkus-bot[bot]

@Karm any chance you could have a look at this one before next Tuesday? I'd let to get all these relatively closely related patches into 3.16 if possible.

gsmet avatar Oct 17 '24 08:10 gsmet

@gsmet Yes, I'll do that. Bumping the priority.

Karm avatar Oct 17 '24 08:10 Karm

Adjusting priority for my human worker @Karm renice -n --16

KarmBot avatar Oct 17 '24 09:10 KarmBot

fddb6d22b6d2 still fails for me.

Karm avatar Oct 21 '24 11:10 Karm

fddb6d2 still fails for me.

I managed to reproduce (and fix) the issue. PTAL when you can.

zakkak avatar Oct 21 '24 11:10 zakkak

fddb6d2 still fails for me.

I managed to reproduce (and fix) the issue. PTAL when you can.

WIP...

Karm avatar Oct 21 '24 14:10 Karm


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b95789b04384720308c8ebe90cf1c93972393832.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 17 Build Failures Logs Raw logs :mag:
:heavy_check_mark: JVM Tests - JDK 21 Logs Raw logs :mag:
Native Tests - Misc4 Build Failures Logs Raw logs :mag:

Full information is available in the Build summary check run. You can consult the Develocity build scans.

Failures

:gear: JVM Tests - JDK 17 #

- Failing: integration-tests/mongodb-panache 

:package: integration-tests/mongodb-panache

io.quarkus.it.mongodb.panache.ReflectionFreeSerializationTest.testReactiveBookEntity line 29 - History - More details - Source on GitHub

java.lang.RuntimeException: 
com.fasterxml.jackson.databind.exc.MismatchedInputException: No content to map due to end-of-input
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 1]
	at io.restassured.internal.path.json.mapping.JsonPathJackson2ObjectDeserializer.deserialize(JsonPathJackson2ObjectDeserializer.java:30)
	at io.restassured.path.json.mapping.JsonPathObjectDeserializer$deserialize.call(Unknown Source)
	at io.restassured.internal.mapping.Jackson2Mapper.deserialize(Jackson2Mapper.groovy:58)
	at io.restassured.mapper.ObjectMapper$deserialize.call(Unknown Source)
	at io.restassured.internal.mapping.ObjectMapping.parseWithJackson2(ObjectMapping.groovy:254)

:gear: Native Tests - Misc4 #

- Failing: integration-tests/opentelemetry-jdbc-instrumentation 

:package: integration-tests/opentelemetry-jdbc-instrumentation

Failed to execute goal io.fabric8:docker-maven-plugin:0.45.1:start (docker-start) on project quarkus-integration-test-opentelemetry-jdbc-instrumentation: I/O Error


Flaky tests - Develocity

:gear: Maven Tests - JDK 17 Windows

:package: integration-tests/maven

io.quarkus.maven.it.TestMojoIT.testThatTheTestsAreReRunMultiModule - History

  • Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils.waitForNextCompletion(TestModeContinuousTestingMavenTestUtils.java:50)
	at io.quarkus.maven.it.LaunchMojoTestBase.testThatTheTestsAreReRunMultiModule(LaunchMojoTestBase.java:56)

quarkus-bot[bot] avatar Oct 21 '24 17:10 quarkus-bot[bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b95789b04384720308c8ebe90cf1c93972393832.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 17 Build :warning: Check → Logs Raw logs :construction:
:heavy_check_mark: JVM Tests - JDK 21 Logs Raw logs :construction:

You can consult the Develocity build scans.

quarkus-bot[bot] avatar Oct 21 '24 21:10 quarkus-bot[bot]

The mongodb failures seem unrelated.

zakkak avatar Oct 22 '24 07:10 zakkak